linux-kernel - Re: [PATCH RFC v3 07/15] md/raid1: convert to use bio_submit_split

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aLhC_1kvyiBgiCXn@infradead.org>
Date: Wed, 3 Sep 2025 06:30:39 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Yu Kuai <yukuai1@...weicloud.com>
Cc: Damien Le Moal <dlemoal@...nel.org>, hch@...radead.org,
	colyli@...nel.org, hare@...e.de, tieren@...as.com, axboe@...nel.dk,
	tj@...nel.org, josef@...icpanda.com, song@...nel.org,
	kmo@...erainc.com, satyat@...gle.com, ebiggers@...gle.com,
	neil@...wn.name, akpm@...ux-foundation.org,
	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
	cgroups@...r.kernel.org, linux-raid@...r.kernel.org,
	yi.zhang@...wei.com, yangerkun@...wei.com, johnny.chenyi@...wei.com,
	"yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH RFC v3 07/15] md/raid1: convert to use
 bio_submit_split_bioset()

On Mon, Sep 01, 2025 at 04:03:22PM +0800, Yu Kuai wrote:
> With this change:
> 1) bio_submit_split_bioset() already fail the bio will split error;
> 2) set R1BIO_Returned;
> 3) raid_end_bio_io() check R1BIO_Returned is set and do nothing with the
> bio;
> 
> And the same with raid10 in patch 8,9;
> 
> Perhaps I'll emphasize there is no function changes and explain a bit.

Please spell the above in the commit log.  Or do the flag changes
separately so that it is even more clear.