lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aLhDp10e2MpKVVyY@infradead.org>
Date: Wed, 3 Sep 2025 06:33:27 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Yu Kuai <yukuai1@...weicloud.com>
Cc: hch@...radead.org, colyli@...nel.org, hare@...e.de, dlemoal@...nel.org,
	tieren@...as.com, axboe@...nel.dk, tj@...nel.org,
	josef@...icpanda.com, song@...nel.org, kmo@...erainc.com,
	satyat@...gle.com, ebiggers@...gle.com, neil@...wn.name,
	akpm@...ux-foundation.org, linux-block@...r.kernel.org,
	linux-kernel@...r.kernel.org, cgroups@...r.kernel.org,
	linux-raid@...r.kernel.org, yukuai3@...wei.com, yi.zhang@...wei.com,
	yangerkun@...wei.com, johnny.chenyi@...wei.com
Subject: Re: [PATCH RFC v3 13/15] block: skip unnecessary checks for split bio

On Mon, Sep 01, 2025 at 11:32:18AM +0800, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@...wei.com>
> 
> Lots of checks are already done while submitting this bio the first
> time, and there is no need to check them again when this bio is
> resubmitted after split.
> 
> Hence factor out a helper submit_split_bio_noacct() for resubmitting
> bio after splitting, only should_fail_bio() and blk_throtl_bio() are
> kept.

As Damien said last run this helper is a bit odd.

I'd just make should_fail_bio non-sttic and merge
submit_split_bio_noacct into bio_submit_split_bioset if that works out.


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ