linux-kernel - Re: [PATCH 1/5] include: linux: Destage VCHIQ interface headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02213561-7a72-474a-be83-98d5ba575f0c@gmx.net>
Date: Wed, 3 Sep 2025 17:03:43 +0200
From: Stefan Wahren <wahrenst@....net>
To: Jai Luthra <jai.luthra@...asonboard.com>,
 Florian Fainelli <florian.fainelli@...adcom.com>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Umang Jain <uajain@...lia.com>,
 Dave Stevenson <dave.stevenson@...pberrypi.com>
Cc: Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Ray Jui
 <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>,
 linux-rpi-kernel@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
 linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
 kernel-list@...pberrypi.com
Subject: Re: [PATCH 1/5] include: linux: Destage VCHIQ interface headers

Am 03.09.25 um 15:48 schrieb Jai Luthra:
> Hi Florian, Stefan,
>
> Quoting Stefan Wahren (2025-08-28 11:49:47)
>> Hi Florian,
>>
>> Am 28.08.25 um 04:17 schrieb Florian Fainelli:
>>>
>>> On 8/27/2025 12:05 PM, Stefan Wahren wrote:
>>>> Hi,
>>>>
>>>> Am 27.08.25 um 16:33 schrieb Umang Jain:
>>>>> On Wed, Aug 27, 2025 at 02:40:16PM +0200, Laurent Pinchart wrote:
>>>>>> Hi Jai,
>>>>>>
>>>>>> Thank you for the patch.
>>>>>>
>>>>>> On Wed, Aug 27, 2025 at 11:54:08AM +0530, Jai Luthra wrote:
>>>>>>> From: Umang Jain <umang.jain@...asonboard.com>
>>>>>>>
>>>>>>> Move the VCHIQ headers from drivers/staging/vc04_services/include to
>>>>>>> include/linux/vchiq
>>>>>>>
>>>>>>> This is done so that they can be shared between the VCHIQ interface
>>>>>>> (which is going to be de-staged in a subsequent commit from staging)
>>>>>>> and the VCHIQ drivers left in the staging/vc04_services (namely
>>>>>>> bcm2835-audio, bcm2835-camera).
>>>>>>>
>>>>>>> The include/linux/vchiq/ provides a central location to serve both
>>>>>>> of these areas.
>>>>>> Lots of SoC-specific headers are stored in include/linux/soc/$vendor/.
>>>>>> This would be include/linux/soc/bcm/vchiq/ in this case. I'm also fine
>>>>>> with include/linux/vchiq/ but other people may have a preference.
>>>>> I agree with this point and I might have missed to notice the
>>>>> include/linux/soc earlier. That's seems a better location to me since
>>>>> it's actually broadcom-specific.
>>>> I would expect that headers and source would be more related.
>>>>
>>>> For example:
>>>>
>>>> include/linux/soc/bcm
>>>>
>>>> drivers/soc/bcm/
>>> This is not Broadcom code, it is Raspberry Pi AFAICT, therefore, just
>>> like drivers/firmware/raspberrypi.c, we would need some namespacing
>>> here that reflects that, ideally.
>> The VCHIQ code originally comes from Broadcom, but the current
>> implementation has been adapted and tested for Raspberry Pi. I'm not
>> against a Raspberry Pi specific namespace.
> Thanks for the suggestions. For v2 I'll use:
>
> include/linux/soc/raspberrypi
> drivers/soc/raspberrypi
I'm fine with this.
>
>> Should this also apply to the DT bindings?
>>
>> Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
>>
>> Best regards
>>
> Thanks,
>      Jai