linux-kernel - Re: [PATCH 2/2] leds: led-class: Add devicetree support to led

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202509031142.WBnVOXZW-lkp@intel.com>
Date: Wed, 3 Sep 2025 11:31:58 +0800
From: kernel test robot <lkp@...el.com>
To: Aleksandrs Vinarskis <alex@...arskis.com>,
	Hans de Goede <hansg@...nel.org>, Lee Jones <lee@...nel.org>,
	Pavel Machek <pavel@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Bryan O'Donoghue <bryan.odonoghue@...aro.org>
Cc: oe-kbuild-all@...ts.linux.dev, linux-leds@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Aleksandrs Vinarskis <alex@...arskis.com>,
	Andy Shevchenko <andy.shevchenko@...il.com>,
	Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH 2/2] leds: led-class: Add devicetree support to led_get()

Hi Aleksandrs,

kernel test robot noticed the following build warnings:

[auto build test WARNING on lee-leds/for-leds-next]
[also build test WARNING on linus/master v6.17-rc4 next-20250902]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Aleksandrs-Vinarskis/leds-led-class-Add-devicetree-support-to-led_get/20250902-191342
base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git for-leds-next
patch link:    https://lore.kernel.org/r/010201990a1f6559-9e836a40-f534-4535-bd59-5e967d80559a-000000%40eu-west-1.amazonses.com
patch subject: [PATCH 2/2] leds: led-class: Add devicetree support to led_get()
config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20250903/202509031142.WBnVOXZW-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250903/202509031142.WBnVOXZW-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509031142.WBnVOXZW-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/leds/led-class.c:281:22: warning: no previous prototype for 'of_led_get' [-Wmissing-prototypes]
     281 | struct led_classdev *of_led_get(struct device_node *np, int index)
         |                      ^~~~~~~~~~


vim +/of_led_get +281 drivers/leds/led-class.c

   272	
   273	/**
   274	 * of_led_get() - request a LED device via the LED framework
   275	 * @np: device node to get the LED device from
   276	 * @index: the index of the LED
   277	 *
   278	 * Returns the LED device parsed from the phandle specified in the "leds"
   279	 * property of a device tree node or a negative error-code on failure.
   280	 */
 > 281	struct led_classdev *of_led_get(struct device_node *np, int index)
   282	{
   283		return __of_led_get(np, index, NULL);
   284	}
   285	EXPORT_SYMBOL_GPL(of_led_get);
   286	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki