linux-kernel - Re: [PATCH 2/2] leds: led-class: Add devicetree support to led

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250903065841.GX2163762@google.com>
Date: Wed, 3 Sep 2025 07:58:41 +0100
From: Lee Jones <lee@...nel.org>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: Aleksandrs Vinarskis <alex@...arskis.com>,
	Hans de Goede <hansg@...nel.org>, Pavel Machek <pavel@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
	linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Andy Shevchenko <andy.shevchenko@...il.com>
Subject: Re: [PATCH 2/2] leds: led-class: Add devicetree support to led_get()

On Wed, 03 Sep 2025, Linus Walleij wrote:

> On Tue, Sep 2, 2025 at 1:10 PM Aleksandrs Vinarskis <alex@...arskis.com> wrote:
> 
> > From: Hans de Goede <hansg@...nel.org>
> >
> > Turn of_led_get() into a more generic __of_led_get() helper function,
> > which can lookup LEDs in devicetree by either name or index.
> 
> I don't really like __inner_function() as naming since it
> is easily confused with __COMPILER_FLAGS__ and also
> with __non_atomic_bitset().
> 
> I would name it of_led_get_inner() simply.

I'm personally okay with '__' to mean private.  There are many examples
of this already.  I'm generally less happy with '__' functions being
exported or otherwise used outside of the subsystem / core that they
reside in.

-- 
Lee Jones [李琼斯]