linux-kernel - Re: [PATCH RFC v3 11/15] md/md-linear: convert to use bio_submit_split

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <238625a0-c9ab-4354-a23e-d8a8bdd869ad@acm.org>
Date: Wed, 3 Sep 2025 10:43:21 -0700
From: Bart Van Assche <bvanassche@....org>
To: Yu Kuai <yukuai1@...weicloud.com>, hch@...radead.org, colyli@...nel.org,
 hare@...e.de, dlemoal@...nel.org, tieren@...as.com, axboe@...nel.dk,
 tj@...nel.org, josef@...icpanda.com, song@...nel.org, kmo@...erainc.com,
 satyat@...gle.com, ebiggers@...gle.com, neil@...wn.name,
 akpm@...ux-foundation.org
Cc: linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
 cgroups@...r.kernel.org, linux-raid@...r.kernel.org, yukuai3@...wei.com,
 yi.zhang@...wei.com, yangerkun@...wei.com, johnny.chenyi@...wei.com
Subject: Re: [PATCH RFC v3 11/15] md/md-linear: convert to use
 bio_submit_split_bioset()

On 8/31/25 8:32 PM, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@...wei.com>
> 
> Unify bio split code, prepare to fix disordered split IO.
> 
> Signed-off-by: Yu Kuai <yukuai3@...wei.com>
> ---
>   drivers/md/md-linear.c | 12 ++----------
>   1 file changed, 2 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/md/md-linear.c b/drivers/md/md-linear.c
> index 59d7963c7843..701e3aac0a21 100644
> --- a/drivers/md/md-linear.c
> +++ b/drivers/md/md-linear.c
> @@ -256,19 +256,11 @@ static bool linear_make_request(struct mddev *mddev, struct bio *bio)
>   
>   	if (unlikely(bio_end_sector(bio) > end_sector)) {
>   		/* This bio crosses a device boundary, so we have to split it */
> -		struct bio *split = bio_split(bio, end_sector - bio_sector,
> +		bio = bio_submit_split_bioset(bio, end_sector - bio_sector,
>   					      GFP_NOIO, &mddev->bio_set);

This patch cannot have been tested because it triggers the following
build error:

drivers/md/md-linear.c: In function ‘linear_make_request’:
./include/linux/gfp_types.h:381:25: error: passing argument 3 of 
‘bio_submit_split_bioset’ makes pointer from integer without a cast 
[-Wint-conversion]
   381 | #define GFP_NOIO        (__GFP_RECLAIM)
       |                         ^~~~~~~~~~~~~~~
       |                         |
       |                         unsigned int

Bart.