linux-kernel - Re: [PATCH RFC v3 14/15] block: fix disordered IO in the case recursive split

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0c345d21-312b-4b83-8296-b8df01b9b819@acm.org>
Date: Wed, 3 Sep 2025 10:52:57 -0700
From: Bart Van Assche <bvanassche@....org>
To: Yu Kuai <hailan@...uai.org.cn>, Christoph Hellwig <hch@...radead.org>,
 Yu Kuai <yukuai1@...weicloud.com>
Cc: colyli@...nel.org, hare@...e.de, dlemoal@...nel.org, tieren@...as.com,
 axboe@...nel.dk, tj@...nel.org, josef@...icpanda.com, song@...nel.org,
 kmo@...erainc.com, satyat@...gle.com, ebiggers@...gle.com, neil@...wn.name,
 akpm@...ux-foundation.org, linux-block@...r.kernel.org,
 linux-kernel@...r.kernel.org, cgroups@...r.kernel.org,
 linux-raid@...r.kernel.org, yukuai3@...wei.com, yi.zhang@...wei.com,
 yangerkun@...wei.com, johnny.chenyi@...wei.com
Subject: Re: [PATCH RFC v3 14/15] block: fix disordered IO in the case
 recursive split

On 9/3/25 9:59 AM, Yu Kuai wrote:
> 在 2025/9/3 21:34, Christoph Hellwig 写道:
>>> +        if (split && !bdev_is_zoned(bio->bi_bdev))
 >>
>> Why are zoned devices special cased here?
>>
> I'm not that sure about zoned device before, I'll remove this checking,
> and mention the problem Bart met in commit message in the next version.

If I keep the bdev_is_zoned() check, test zbd/014 fails. If I remove it,
test zbd/014 passes. I think that's a strong argument to remove that
check. Test zbd/014 is not yet in the blktests repository but is
available here:
https://lore.kernel.org/linux-block/a8a714c7-de3d-4cc9-8c23-38b8dc06f5bb@acm.org/

Thanks,

Bart.