linux-kernel - Re: [PATCH RFC v3 11/15] md/md-linear: convert to use bio_submit_split

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5db345bd-fee5-8dce-3f61-1f8efb758f05@huaweicloud.com>
Date: Thu, 4 Sep 2025 08:50:22 +0800
From: Yu Kuai <yukuai1@...weicloud.com>
To: Bart Van Assche <bvanassche@....org>, Yu Kuai <yukuai1@...weicloud.com>,
 hch@...radead.org, colyli@...nel.org, hare@...e.de, dlemoal@...nel.org,
 tieren@...as.com, axboe@...nel.dk, tj@...nel.org, josef@...icpanda.com,
 song@...nel.org, kmo@...erainc.com, satyat@...gle.com, ebiggers@...gle.com,
 neil@...wn.name, akpm@...ux-foundation.org
Cc: linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
 cgroups@...r.kernel.org, linux-raid@...r.kernel.org, yi.zhang@...wei.com,
 yangerkun@...wei.com, johnny.chenyi@...wei.com,
 "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH RFC v3 11/15] md/md-linear: convert to use
 bio_submit_split_bioset()

Hi,

在 2025/09/04 1:43, Bart Van Assche 写道:
> On 8/31/25 8:32 PM, Yu Kuai wrote:
>> From: Yu Kuai <yukuai3@...wei.com>
>>
>> Unify bio split code, prepare to fix disordered split IO.
>>
>> Signed-off-by: Yu Kuai <yukuai3@...wei.com>
>> ---
>>   drivers/md/md-linear.c | 12 ++----------
>>   1 file changed, 2 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/md/md-linear.c b/drivers/md/md-linear.c
>> index 59d7963c7843..701e3aac0a21 100644
>> --- a/drivers/md/md-linear.c
>> +++ b/drivers/md/md-linear.c
>> @@ -256,19 +256,11 @@ static bool linear_make_request(struct mddev 
>> *mddev, struct bio *bio)
>>       if (unlikely(bio_end_sector(bio) > end_sector)) {
>>           /* This bio crosses a device boundary, so we have to split 
>> it */
>> -        struct bio *split = bio_split(bio, end_sector - bio_sector,
>> +        bio = bio_submit_split_bioset(bio, end_sector - bio_sector,
>>                             GFP_NOIO, &mddev->bio_set);
> 
> This patch cannot have been tested because it triggers the following
> build error:

Yes, sorry about that. As I said I only tested with raid5 with this
RFC version. I will at least run all the test cases in the next formal
version.

Thanks,
Kuai

> 
> drivers/md/md-linear.c: In function ‘linear_make_request’:
> ./include/linux/gfp_types.h:381:25: error: passing argument 3 of 
> ‘bio_submit_split_bioset’ makes pointer from integer without a cast 
> [-Wint-conversion]
>    381 | #define GFP_NOIO        (__GFP_RECLAIM)
>        |                         ^~~~~~~~~~~~~~~
>        |                         |
>        |                         unsigned int
> 
> Bart.
> .
>