[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250903184858.GF361157@horms.kernel.org>
Date: Wed, 3 Sep 2025 19:48:58 +0100
From: Simon Horman <horms@...nel.org>
To: Vladimir Oltean <vladimir.oltean@....com>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net 1/2] net: phylink: add lock for serializing
concurrent pl->phydev writes with resolver
On Wed, Sep 03, 2025 at 06:23:47PM +0300, Vladimir Oltean wrote:
...
> @@ -1582,8 +1584,11 @@ static void phylink_resolve(struct work_struct *w)
> struct phylink_link_state link_state;
> bool mac_config = false;
> bool retrigger = false;
> + struct phy_device *phy;
> bool cur_link_state;
>
> + mutex_lock(&pl->phy_lock);
> + phy = pl->phydev;
Hi Vladimir,
I guess this is an artifact of the development of this patchset.
Whatever the case, phy is set but otherwise unused in this function.
This makes CI lightup like a Christmas tree.
And it's a bit too early in the year for that.
> mutex_lock(&pl->state_mutex);
> cur_link_state = phylink_link_is_up(pl);
>
...
--
pw-bot: cr
Powered by blists - more mailing lists