[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <646c8a39-c78e-4c2c-b820-d7d57e0a85fc@csgroup.eu>
Date: Wed, 3 Sep 2025 06:58:31 +0200
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Rob Herring <robh@...nel.org>
Cc: Qiang Zhao <qiang.zhao@....com>, Linus Walleij
<linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, linux-kernel@...r.kernel.org,
linuxppc-dev@...ts.ozlabs.org, linux-arm-kernel@...ts.infradead.org,
linux-gpio@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v5 6/7] dt-bindings: soc: fsl: qe: Convert QE GPIO to DT
schema
Hi Rob,
Le 02/09/2025 à 23:24, Rob Herring a écrit :
> On Mon, Sep 01, 2025 at 02:05:13PM +0200, Christophe Leroy wrote:
>> Convert QE QPIO devicetree binding to DT schema.
>>
>> Signed-off-by: Christophe Leroy <christophe.leroy@...roup.eu>
>> ---
>> v5: New
>> ---
>
>> +
>> +properties:
>> + compatible:
>> + items:
>> + - enum:
>> + - fsl,chip-qe-pario-bank
>> + - const: fsl,mpc8323-qe-pario-bank
>> +
snip
>
>> + compatible = "fsl,mpc8360-qe-pario-bank", "fsl,mpc8323-qe-pario-bank";
>
> Doesn't match the schema.
>
Can you be more explicit ? Is it the 'mpc8360' ? It is the 'chip'.
bindings/soc/fsl/cpm_qe/qe/par_io.txt was saying:
- compatible : should be "fsl,<chip>-qe-pario-bank",
"fsl,mpc8323-qe-pario-bank".
Which I first translated in yaml as :
properties:
compatible:
items:
- enum:
- fsl,<chip>-qe-pario-bank
- const: fsl,mpc8323-qe-pario-bank
But 'make dt_binding_check' complained about the < > around 'chip' so I
removed them.
How should it be described ?
Thanks
Christophe
Powered by blists - more mailing lists