lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2add01dc1c9d$7b5cba30$72162e90$@samsung.com>
Date: Wed, 3 Sep 2025 15:39:21 +0900
From: "DooHyun Hwang" <dh0421.hwang@...sung.com>
To: "'Bart Van Assche'" <bvanassche@....org>, <linux-scsi@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <alim.akhtar@...sung.com>,
	<avri.altman@....com>, <James.Bottomley@...senPartnership.com>,
	<martin.petersen@...cle.com>, <peter.wang@...iatek.com>,
	<manivannan.sadhasivam@...aro.org>, <quic_mnaresh@...cinc.com>
Cc: <grant.jung@...sung.com>, <jt77.jang@...sung.com>,
	<junwoo80.lee@...sung.com>, <jangsub.yi@...sung.com>,
	<sh043.lee@...sung.com>, <cw9316.lee@...sung.com>,
	<sh8267.baek@...sung.com>, <wkon.kim@...sung.com>
Subject: RE: [PATCH 1/2] scsi: ufs: Add an enum for ufs_trace to check ufs
 cmd error

On 9/2/25 9:35 AM, Bart Van Assche wrote:
> On 9/1/25 6:09 PM, DooHyun Hwang wrote:
> > The UFS_CMD_ERR stands for "command completion error."
> 
> I've never before seen anyone abbreviating "completion" as "CMD".
> Please choose a better enumeration label name.
> 
> Bart.

When I reviewed the UFS_CMD_TRACE_STRINGS definition,
I noticed that "query_complete_err" is referred to as UFS_QUERY_ERR,
and "tm_complete_err" is referred to as UFS_TM_ERR.

I followed the naming convention specified in this STRINGS definition,
but I’m not entirely clear on what changes are being requested.

Could you please provide some guidance or suggestions?

Thank you.
DooHyun Hwang.



Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ