[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250903101002.GD13448@pendragon.ideasonboard.com>
Date: Wed, 3 Sep 2025 12:10:02 +0200
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Bin Du <Bin.Du@....com>
Cc: mchehab@...nel.org, hverkuil@...all.nl, bryan.odonoghue@...aro.org,
sakari.ailus@...ux.intel.com,
prabhakar.mahadev-lad.rj@...renesas.com,
linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
sultan@...neltoast.com, pratap.nirujogi@....com,
benjamin.chan@....com, king.li@....com, gjorgji.rosikopulos@....com,
Phil.Jawich@....com, Dominic.Antony@....com,
mario.limonciello@....com, richard.gong@....com, anson.tsao@....com,
Svetoslav Stoilov <Svetoslav.Stoilov@....com>
Subject: Re: [PATCH v3 4/7] media: platform: amd: isp4 subdev and firmware
loading handling added
On Thu, Aug 28, 2025 at 06:08:08PM +0800, Bin Du wrote:
> Isp4 sub-device is implementing v4l2 sub-device interface. It has one
> capture video node, and supports only preview stream. It manages firmware
> states, stream configuration and mipi phy configuration. This change also
> adds interrupt handling and notification for isp firmware to isp-subdevice.
>
> Co-developed-by: Svetoslav Stoilov <Svetoslav.Stoilov@....com>
> Signed-off-by: Svetoslav Stoilov <Svetoslav.Stoilov@....com>
> Signed-off-by: Bin Du <Bin.Du@....com>
> ---
> MAINTAINERS | 2 +
> drivers/media/platform/amd/isp4/Makefile | 3 +-
> drivers/media/platform/amd/isp4/isp4.c | 120 +-
> drivers/media/platform/amd/isp4/isp4.h | 8 +-
> drivers/media/platform/amd/isp4/isp4_subdev.c | 1096 +++++++++++++++++
> drivers/media/platform/amd/isp4/isp4_subdev.h | 131 ++
> 6 files changed, 1347 insertions(+), 13 deletions(-)
> create mode 100644 drivers/media/platform/amd/isp4/isp4_subdev.c
> create mode 100644 drivers/media/platform/amd/isp4/isp4_subdev.h
[snip]
> diff --git a/drivers/media/platform/amd/isp4/isp4.h b/drivers/media/platform/amd/isp4/isp4.h
> index 8535f662ab49..00ac11ed8fb0 100644
> --- a/drivers/media/platform/amd/isp4/isp4.h
> +++ b/drivers/media/platform/amd/isp4/isp4.h
> @@ -6,19 +6,21 @@
> #ifndef _ISP4_H_
> #define _ISP4_H_
>
> +#include <drm/amd/isp.h>
> #include <linux/mutex.h>
> -#include <media/v4l2-device.h>
> -#include <media/videobuf2-memops.h>
> -#include <media/videobuf2-vmalloc.h>
> +#include "isp4_subdev.h"
>
> #define ISP4_GET_ISP_REG_BASE(isp4sd) (((isp4sd))->mmio)
>
> struct isp4_device {
> struct v4l2_device v4l2_dev;
> + struct isp4_subdev isp_sdev;
> struct media_device mdev;
>
> + struct isp_platform_data *pltf_data;
> struct platform_device *pdev;
> struct notifier_block i2c_nb;
> + struct v4l2_async_notifier notifier;
As far as I can tell, i2c_nb and notifier are not used anymore.
> };
>
> #endif /* _ISP4_H_ */
[snip]
--
Regards,
Laurent Pinchart
Powered by blists - more mailing lists