linux-kernel - Re: [PATCH] media: pci: Add core driver for Techwell TW68xx video capture devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202509041912.qtRHikwE-lkp@intel.com>
Date: Thu, 4 Sep 2025 19:32:53 +0800
From: kernel test robot <lkp@...el.com>
To: Fidal Palamparambil <palamparambilfidal089@...il.com>,
	kgdb-bugreport@...ts.sourceforge.net
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	linux-kernel@...r.kernel.org, daniel.thompson@...aro.org,
	dianders@...omium.org,
	Fidal Palamparambil <hellomystoryswherei@...il.com>
Subject: Re: [PATCH] media: pci: Add core driver for Techwell TW68xx video
 capture devices

Hi Fidal,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.17-rc4 next-20250904]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Fidal-Palamparambil/media-pci-Add-core-driver-for-Techwell-TW68xx-video-capture-devices/20250904-014821
base:   linus/master
patch link:    https://lore.kernel.org/r/20250903174657.1689-1-hellomystoryswherei%40gmail.com
patch subject: [PATCH] media: pci: Add core driver for Techwell TW68xx video capture devices
config: i386-buildonly-randconfig-006-20250904 (https://download.01.org/0day-ci/archive/20250904/202509041912.qtRHikwE-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250904/202509041912.qtRHikwE-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509041912.qtRHikwE-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/media/pci/tw68/tw68-core.c:381:18: warning: unused variable 'pci_dev' [-Wunused-variable]
     381 |         struct pci_dev *pci_dev = to_pci_dev(dev_d);
         |                         ^~~~~~~
   1 warning generated.


vim +/pci_dev +381 drivers/media/pci/tw68/tw68-core.c

   378	
   379	static int __maybe_unused tw68_resume(struct device *dev_d)
   380	{
 > 381		struct pci_dev *pci_dev = to_pci_dev(dev_d);
   382		struct v4l2_device *v4l2_dev = dev_get_drvdata(dev_d);
   383		struct tw68_dev *dev = container_of(v4l2_dev, struct tw68_dev, v4l2_dev);
   384		struct tw68_buf *buf;
   385		unsigned long flags;
   386	
   387		/* Do things that are done in tw68_initdev,
   388		 * except for initializing memory structures.
   389		 */
   390		msleep(100);
   391	
   392		tw68_hw_init1(dev);
   393		tw68_set_tvnorm_hw(dev);
   394	
   395		/* Restore interrupt mask */
   396		tw_setl(TW68_INTMASK, dev->pci_irqmask);
   397	
   398		/* Resume unfinished buffer(s) */
   399		spin_lock_irqsave(&dev->slock, flags);
   400		if (!list_empty(&dev->active)) {
   401			buf = container_of(dev->active.next, struct tw68_buf, list);
   402			tw68_video_start_dma(dev, buf);
   403		}
   404		spin_unlock_irqrestore(&dev->slock, flags);
   405	
   406		return 0;
   407	}
   408	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki