linux-kernel - [PATCH] rv/ltl_monitor: adapt handle_task_newtask to u64 clone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20250904-trace-task-newtask-fix-callbacks-v1-1-8edb3d557365@siemens-energy.com>
Date: Thu, 04 Sep 2025 13:36:52 +0200
From: Simon Schuster via B4 Relay <devnull+schuster.simon.siemens-energy.com@...nel.org>
To: Steven Rostedt <rostedt@...dmis.org>, 
 Christian Brauner <brauner@...nel.org>, 
 Stephen Rothwell <sfr@...b.auug.org.au>
Cc: David Hildenbrand <david@...hat.com>, 
 Lorenzo Stoakes <lorenzo.stoakes@...cle.com>, Arnd Bergmann <arnd@...db.de>, 
 linux-trace-kernel@...r.kernel.org, linux-kernel@...r.kernel.org, 
 kernel test robot <lkp@...el.com>, 
 Simon Schuster <schuster.simon@...mens-energy.com>
Subject: [PATCH] rv/ltl_monitor: adapt handle_task_newtask to u64
 clone_flags

From: Simon Schuster <schuster.simon@...mens-energy.com>

Since commit edd3cb05c00a ("copy_process: pass clone_flags as u64 across
calltree") the task_newtask trace event exposes clone_flags as u64 to
its callbacks.

However, ltl_monitor was not adapted, resulting in a faulty callback.
This also resulted in an lkp build warning due to
-Wincompatible-pointer-types.

Fixes: edd3cb05c00a ("copy_process: pass clone_flags as u64 across calltree")
Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
Closes: https://lore.kernel.org/lkml/20250904113334.18822d43@canb.auug.org.au/
Reported-by: kernel test robot <lkp@...el.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202509040134.bQVbm7ja-lkp@intel.com/
Signed-off-by: Simon Schuster <schuster.simon@...mens-energy.com>
---
I did further search for other in-tree users of the task_newtask
callback, but the trace macros make it a bit harder. Yet, as far as I
could see, there are none, so this patch hopefully resolves the problem
for good. The other matches all relate to "tp_btf/task_newtask", which
seems to be unaffected.

With this patch, ARCH=S390 allmodconfig -- that originally tripped the
LKP builds -- now builds without further -Wincompatible-pointer-types
warnings.

Sorry for causing this trouble, and thanks to Stephen Rothwell for
testing/reporting.
---
 include/rv/ltl_monitor.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/rv/ltl_monitor.h b/include/rv/ltl_monitor.h
index 67031a774e3d..5368cf5fd623 100644
--- a/include/rv/ltl_monitor.h
+++ b/include/rv/ltl_monitor.h
@@ -56,7 +56,7 @@ static void ltl_task_init(struct task_struct *task, bool task_creation)
 	ltl_atoms_fetch(task, mon);
 }
 
-static void handle_task_newtask(void *data, struct task_struct *task, unsigned long flags)
+static void handle_task_newtask(void *data, struct task_struct *task, u64 flags)
 {
 	ltl_task_init(task, true);
 }

---
base-commit: edd3cb05c00a040dc72bed20b14b5ba865188bce
change-id: 20250904-trace-task-newtask-fix-callbacks-b158634c59da

Best regards,
-- 
Simon Schuster <schuster.simon@...mens-energy.com>