linux-kernel - Re: [PATCH 4/4] drm/radeon/pm: Remove redundant ternary operators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_Mf7xsK3v2r4EKR8crOQ=1WxhvTGNEmQAKLkY3XJuBXpg@mail.gmail.com>
Date: Thu, 4 Sep 2025 10:14:41 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: Liao Yuanhong <liaoyuanhong@...o.com>
Cc: Alex Deucher <alexander.deucher@....com>, 
	Christian König <christian.koenig@....com>, 
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	"open list:RADEON and AMDGPU DRM DRIVERS" <amd-gfx@...ts.freedesktop.org>, 
	"open list:DRM DRIVERS" <dri-devel@...ts.freedesktop.org>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/4] drm/radeon/pm: Remove redundant ternary operators

Applied the series.  Thanks!

Alex

On Thu, Sep 4, 2025 at 7:49 AM Liao Yuanhong <liaoyuanhong@...o.com> wrote:
>
> For ternary operators in the form of "a ? true : false", if 'a' itself
> returns a boolean result, the ternary operator can be omitted. Remove
> redundant ternary operators to clean up the code.
>
> Signed-off-by: Liao Yuanhong <liaoyuanhong@...o.com>
> ---
>  drivers/gpu/drm/radeon/radeon_pm.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_pm.c b/drivers/gpu/drm/radeon/radeon_pm.c
> index b4fb7e70320b..a855a96dd2ea 100644
> --- a/drivers/gpu/drm/radeon/radeon_pm.c
> +++ b/drivers/gpu/drm/radeon/radeon_pm.c
> @@ -907,8 +907,7 @@ static void radeon_dpm_thermal_work_handler(struct work_struct *work)
>
>  static bool radeon_dpm_single_display(struct radeon_device *rdev)
>  {
> -       bool single_display = (rdev->pm.dpm.new_active_crtc_count < 2) ?
> -               true : false;
> +       bool single_display = rdev->pm.dpm.new_active_crtc_count < 2;
>
>         /* check if the vblank period is too short to adjust the mclk */
>         if (single_display && rdev->asic->dpm.vblank_too_short) {
> --
> 2.34.1
>