linux-kernel - Re: [PATCH v5 6/9] phy: phy-can-transceiver: Add support for TJA105{1,7}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aLmgs6aAm/2Rj+Bo@lizhi-Precision-Tower-5810>
Date: Thu, 4 Sep 2025 10:22:43 -0400
From: Frank Li <Frank.li@....com>
To: Peng Fan <peng.fan@....com>
Cc: Marc Kleine-Budde <mkl@...gutronix.de>,
	Vincent Mailhol <mailhol.vincent@...adoo.fr>,
	Vinod Koul <vkoul@...nel.org>,
	Kishon Vijay Abraham I <kishon@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Aswath Govindraju <a-govindraju@...com>,
	Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, Haibo Chen <haibo.chen@....com>,
	linux-can@...r.kernel.org, linux-phy@...ts.infradead.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v5 6/9] phy: phy-can-transceiver: Add support for
 TJA105{1,7}

On Thu, Sep 04, 2025 at 04:36:49PM +0800, Peng Fan wrote:
> Support TJA105{1,7} which are a single channel high-speed CAN transceiver
> with silent mode supported.
>
> phy mode is not implemented as of now. silent settings are kept in
> phy_power_on and phy_power_off. After phy mode is supported, the silent
> settings could be moved to phy_set_mode.

nit: function need "()". phy_power_on()

Reviewed-by: Frank Li <Frank.Li@....com>
>
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---
>  drivers/phy/phy-can-transceiver.c | 35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
>
> diff --git a/drivers/phy/phy-can-transceiver.c b/drivers/phy/phy-can-transceiver.c
> index ccb29e1dfe0d07005b4bcd8fefa2787292d921a0..d9fd3564970695d5460ffdc4e8636dd7638d64a2 100644
> --- a/drivers/phy/phy-can-transceiver.c
> +++ b/drivers/phy/phy-can-transceiver.c
> @@ -18,10 +18,12 @@ struct can_transceiver_data {
>  #define CAN_TRANSCEIVER_STB_PRESENT	BIT(0)
>  #define CAN_TRANSCEIVER_EN_PRESENT	BIT(1)
>  #define CAN_TRANSCEIVER_DUAL_CH		BIT(2)
> +#define CAN_TRANSCEIVER_SILENT_PRESENT	BIT(3)
>  };
>
>  struct can_transceiver_phy {
>  	struct phy *generic_phy;
> +	struct gpio_desc *silent_gpio;
>  	struct gpio_desc *standby_gpio;
>  	struct gpio_desc *enable_gpio;
>  	struct can_transceiver_priv *priv;
> @@ -47,6 +49,10 @@ static int can_transceiver_phy_power_on(struct phy *phy)
>  		}
>  	}
>
> +	ret = gpiod_set_value_cansleep(can_transceiver_phy->silent_gpio, 0);
> +	if (ret)
> +		return ret;
> +
>  	ret = gpiod_set_value_cansleep(can_transceiver_phy->standby_gpio, 0);
>  	if (ret)
>  		return ret;
> @@ -60,6 +66,10 @@ static int can_transceiver_phy_power_off(struct phy *phy)
>  	struct can_transceiver_phy *can_transceiver_phy = phy_get_drvdata(phy);
>  	int ret;
>
> +	ret = gpiod_set_value_cansleep(can_transceiver_phy->silent_gpio, 1);
> +	if (ret)
> +		return ret;
> +
>  	ret = gpiod_set_value_cansleep(can_transceiver_phy->standby_gpio, 1);
>  	if (ret)
>  		return ret;
> @@ -92,6 +102,14 @@ static const struct can_transceiver_data tja1048_drvdata = {
>  	.flags = CAN_TRANSCEIVER_STB_PRESENT | CAN_TRANSCEIVER_DUAL_CH,
>  };
>
> +static const struct can_transceiver_data tja1051_drvdata = {
> +	.flags = CAN_TRANSCEIVER_SILENT_PRESENT | CAN_TRANSCEIVER_EN_PRESENT,
> +};
> +
> +static const struct can_transceiver_data tja1057_drvdata = {
> +	.flags = CAN_TRANSCEIVER_SILENT_PRESENT,
> +};
> +
>  static const struct of_device_id can_transceiver_phy_ids[] = {
>  	{
>  		.compatible = "ti,tcan1042",
> @@ -105,6 +123,14 @@ static const struct of_device_id can_transceiver_phy_ids[] = {
>  		.compatible = "nxp,tja1048",
>  		.data = &tja1048_drvdata
>  	},
> +	{
> +		.compatible = "nxp,tja1051",
> +		.data = &tja1051_drvdata
> +	},
> +	{
> +		.compatible = "nxp,tja1057",
> +		.data = &tja1057_drvdata
> +	},
>  	{
>  		.compatible = "nxp,tjr1443",
>  		.data = &tcan1043_drvdata
> @@ -150,6 +176,7 @@ static int can_transceiver_phy_probe(struct platform_device *pdev)
>  	const struct can_transceiver_data *drvdata;
>  	const struct of_device_id *match;
>  	struct phy *phy;
> +	struct gpio_desc *silent_gpio;
>  	struct gpio_desc *standby_gpio;
>  	struct gpio_desc *enable_gpio;
>  	struct mux_state *mux_state;
> @@ -213,6 +240,14 @@ static int can_transceiver_phy_probe(struct platform_device *pdev)
>  			priv->can_transceiver_phy[i].enable_gpio = enable_gpio;
>  		}
>
> +		if (drvdata->flags & CAN_TRANSCEIVER_SILENT_PRESENT) {
> +			silent_gpio = devm_gpiod_get_index_optional(dev, "silent", i,
> +								    GPIOD_OUT_LOW);
> +			if (IS_ERR(silent_gpio))
> +				return PTR_ERR(silent_gpio);
> +			priv->can_transceiver_phy[i].silent_gpio = silent_gpio;
> +		}
> +
>  		phy_set_drvdata(priv->can_transceiver_phy[i].generic_phy,
>  				&priv->can_transceiver_phy[i]);
>  	}
>
> --
> 2.37.1
>