linux-kernel - Re: [PATCH v2] drm/panthor: validate group queue count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7a5be556-89ee-420c-96d7-129be6808137@arm.com>
Date: Thu, 4 Sep 2025 16:16:52 +0100
From: Steven Price <steven.price@....com>
To: Chia-I Wu <olvaffe@...il.com>,
 Boris Brezillon <boris.brezillon@...labora.com>,
 Liviu Dudau <liviu.dudau@....com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Grant Likely <grant.likely@...aro.org>, Heiko Stuebner <heiko@...ech.de>,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] drm/panthor: validate group queue count

On 03/09/2025 20:21, Chia-I Wu wrote:
> A panthor group can have at most MAX_CS_PER_CSG panthor queues.
> 
> Fixes: 4bdca11507928 ("drm/panthor: Add the driver frontend block")
> Signed-off-by: Chia-I Wu <olvaffe@...il.com>
> Reviewed-by: Boris Brezillon <boris.brezillon@...labora.com> # v1
> Reviewed-by: Steven Price <steven.price@....com>

Pushed to drm-misc-fixes.

Thanks,
Steve

> 
> ---
> v2:
>  - move validation up to panthor_ioctl_group_create
>  - add Fixes tag
> ---
>  drivers/gpu/drm/panthor/panthor_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/panthor/panthor_drv.c
> index 9256806eb6623..4c202fc5ce050 100644
> --- a/drivers/gpu/drm/panthor/panthor_drv.c
> +++ b/drivers/gpu/drm/panthor/panthor_drv.c
> @@ -1094,7 +1094,7 @@ static int panthor_ioctl_group_create(struct drm_device *ddev, void *data,
>  	struct drm_panthor_queue_create *queue_args;
>  	int ret;
>  
> -	if (!args->queues.count)
> +	if (!args->queues.count || args->queues.count > MAX_CS_PER_CSG)
>  		return -EINVAL;
>  
>  	ret = PANTHOR_UOBJ_GET_ARRAY(queue_args, &args->queues);