linux-kernel - Re: [PATCH v4 1/6] dt-bindings: phy: qcom,sc8280xp-qmp-usb43dp: Reference usb-switch.yaml to allow mode-switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <db5220ad-6153-4f04-89be-5d74838151b1@oss.qualcomm.com>
Date: Thu, 4 Sep 2025 17:18:07 +0200
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Rob Herring <robh@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>
Cc: Vinod Koul <vkoul@...nel.org>, Kishon Vijay Abraham I
 <kishon@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Marijn Suijten <marijn.suijten@...ainline.org>,
        linux-arm-msm@...r.kernel.org, linux-phy@...ts.infradead.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Krzysztof Kozlowski <krzk@...nel.org>
Subject: Re: [PATCH v4 1/6] dt-bindings: phy: qcom,sc8280xp-qmp-usb43dp:
 Reference usb-switch.yaml to allow mode-switch

On 8/22/25 11:20 PM, Rob Herring wrote:
> On Thu, Aug 07, 2025 at 06:33:19PM +0200, Konrad Dybcio wrote:
>> From: Neil Armstrong <neil.armstrong@...aro.org>
>>
>> The QMP USB3/DP Combo PHY can work in 3 modes:
>> - DisplayPort Only
>> - USB3 Only
>> - USB3 + DisplayPort Combo mode
>>
>> In order to switch between those modes, the PHY needs to receive
>> Type-C events, allow marking to the phy with the mode-switch
>> property in order to allow the PHY to Type-C events.
>>
>> Reference usb-switch.yaml as a simpler way to allow the mode-switch
>> property instead of duplicating the property definition.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@...aro.org>
>> Reviewed-by: Krzysztof Kozlowski <krzk@...nel.org>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
>> ---
>>  .../devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml     | 7 +++----
>>  1 file changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
>> index 38ce04c35d945d0d8d319191c241920810ee9005..c8bc512df08b5694c8599f475de78679a4438449 100644
>> --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
>> +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
>> @@ -73,10 +73,8 @@ properties:
>>      description:
>>        See include/dt-bindings/phy/phy-qcom-qmp.h
>>  
>> -  orientation-switch:
>> -    description:
>> -      Flag the PHY as possible handler of USB Type-C orientation switching
>> -    type: boolean
>> +  mode-switch: true
>> +  orientation-switch: true
>>  
>>    ports:
>>      $ref: /schemas/graph.yaml#/properties/ports
>> @@ -106,6 +104,7 @@ required:
>>    - "#phy-cells"
>>  
>>  allOf:
>> +  - $ref: /schemas/usb/usb-switch.yaml#
> 
> As reported already in this thread, this adds a crap load of warnings as 
> it makes ports or port required. Sigh. Can QCom folks pay more attention 
> to this please. Every cycle the number goes up though that's often 
> temporary because there's no coordination of taking .dts files after 
> bindings. But generally, progress on QCom warnings has stalled.
> 
> Here's the top (bottom?) platforms in arm64. The first number is 
> total warnings. The 2nd number is unique warnings (to remove inflated 
> numbers due to lots of boards per SoC).

I'm sorry this happened, Rob.

I assumed this was a solved problem as I picked up this series, but
of course not testing always ends up biting..

Konrad