linux-kernel - Re: [PATCH v6 2/3] PCI: qcom: fix macro typo for CURSOR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250904161707.GA1265471@bhelgaas>
Date: Thu, 4 Sep 2025 11:17:07 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Ziyue Zhang <ziyue.zhang@....qualcomm.com>
Cc: andersson@...nel.org, konradybcio@...nel.org, robh@...nel.org,
	krzk+dt@...nel.org, conor+dt@...nel.org, jingoohan1@...il.com,
	mani@...nel.org, lpieralisi@...nel.org, kwilczynski@...nel.org,
	bhelgaas@...gle.com, johan+linaro@...nel.org, vkoul@...nel.org,
	kishon@...nel.org, neil.armstrong@...aro.org, abel.vesa@...aro.org,
	kw@...ux.com, linux-arm-msm@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org, linux-phy@...ts.infradead.org,
	qiang.yu@....qualcomm.com, quic_krichai@...cinc.com,
	quic_vbadigan@...cinc.com,
	Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Subject: Re: [PATCH v6 2/3] PCI: qcom: fix macro typo for CURSOR

On Thu, Sep 04, 2025 at 02:52:24PM +0800, Ziyue Zhang wrote:
> Corrected a typo in the macro name GEN3_EQ_FMDC_MAX_PRE_CURSOR_DELTA and
> GEN3_EQ_FMDC_MAX_POST_CURSOR_DELTA to ensure consistency and avoid
> potential issues.

In subject, s/fix macro/Fix macro/ to follow precedent.

s/Corrected/Correct/ for imperative mood.

I'd stop after GEN3_EQ_FMDC_MAX_POST_CURSOR_DELTA.  Pointless to go on
and talk about consistency and issues.  It's a simple typo fix.

No need to repost for this.

> -#define GEN3_EQ_FMDC_MAX_PRE_CUSROR_DELTA	GENMASK(13, 10)
> -#define GEN3_EQ_FMDC_MAX_POST_CUSROR_DELTA	GENMASK(17, 14)
> +#define GEN3_EQ_FMDC_MAX_PRE_CURSOR_DELTA	GENMASK(13, 10)
> +#define GEN3_EQ_FMDC_MAX_POST_CURSOR_DELTA	GENMASK(17, 14)