linux-kernel - Re: [PATCH RFC v3 02/15] block: add QUEUE_FLAG_BIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aLkfHW2KuNvrcYyN@infradead.org>
Date: Wed, 3 Sep 2025 22:09:49 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Yu Kuai <yukuai1@...weicloud.com>
Cc: Yu Kuai <hailan@...uai.org.cn>, Christoph Hellwig <hch@...radead.org>,
	colyli@...nel.org, hare@...e.de, dlemoal@...nel.org,
	tieren@...as.com, axboe@...nel.dk, tj@...nel.org,
	josef@...icpanda.com, song@...nel.org, kmo@...erainc.com,
	satyat@...gle.com, ebiggers@...gle.com, neil@...wn.name,
	akpm@...ux-foundation.org, linux-block@...r.kernel.org,
	linux-kernel@...r.kernel.org, cgroups@...r.kernel.org,
	linux-raid@...r.kernel.org, yi.zhang@...wei.com,
	yangerkun@...wei.com, johnny.chenyi@...wei.com,
	"yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH RFC v3 02/15] block: add QUEUE_FLAG_BIO_ISSUE

On Thu, Sep 04, 2025 at 10:44:32AM +0800, Yu Kuai wrote:
> - it's only used by iolatency, which can only be enabled for rq-based
> disks;
> - For bio that is submitted the first time, blk_cgroup_bio_start() is
> called from submit_bio_no_acct_nocheck(), where q_usage_counter is not
> grabbed yet, hence it's not safe to enable that flag while enabling
> iolatency.

Yes, keeping more things in blk-mq is always good.

> -void blk_mq_submit_bio(struct bio *bio)
> +void b k_mq_submit_bio(struct bio *bio)

This got mangled somehow.