linux-kernel - Re: [PATCH v5 1/3] pinctrl: qcom: lpass-lpi: Add ability to use custom pin offsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3a00018f-7573-43c6-867f-eff4041c0ca7@oss.qualcomm.com>
Date: Thu, 4 Sep 2025 11:05:08 +0200
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Nickolay Goppen <setotau@...nlining.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht, linux@...nlining.org,
        Nickolay Goppen <setotau@...dex.ru>
Subject: Re: [PATCH v5 1/3] pinctrl: qcom: lpass-lpi: Add ability to use
 custom pin offsets

On 9/3/25 3:39 PM, Nickolay Goppen wrote:
> By default pin_offset is calculated by formula: LPI_TLMM_REG_OFFSET * pin_id.
> However not all platforms are using this pin_offset formula (e.g. SDM660 LPASS
> LPI uses a predefined array of offsets [1]), so extend lpi_pingroup struct
> with pin_offset field, introduce extended LPI_PINGROUP_OFFSET macro with
> pin_offet field and introduce LPI_FLAG_USE_PREDEFINED_PIN_OFFSET flag.
> This adds an ability to use predefined offset for pin if it exists.
> 
> [1] https://git.codelinaro.org/clo/la/kernel/msm-4.4/-/blob/LA.UM.7.2.c27-07400-sdm660.0/drivers/pinctrl/qcom/pinctrl-lpi.c#L107
> 
> Signed-off-by: Nickolay Goppen <setotau@...nlining.org>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>

Konrad