linux-kernel - Re: [PATCH 03/19] dt-bindings: soc: mobileye: add eyeQ7H compatibles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250904-pristine-unicorn-of-greatness-40eca6@kuoka>
Date: Thu, 4 Sep 2025 11:22:16 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Benoît Monin <benoit.monin@...tlin.com>
Cc: Vladimir Kondratiev <vladimir.kondratiev@...ileye.com>, 
	Gregory CLEMENT <gregory.clement@...tlin.com>, Théo Lebrun <theo.lebrun@...tlin.com>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Thomas Bogendoerfer <tsbogend@...ha.franken.de>, 
	Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, 
	Philipp Zabel <p.zabel@...gutronix.de>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>, 
	linux-mips@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-clk@...r.kernel.org, Tawfik Bayouk <tawfik.bayouk@...ileye.com>, 
	Sari Khoury <sari.khoury@...ileye.com>
Subject: Re: [PATCH 03/19] dt-bindings: soc: mobileye: add eyeQ7H compatibles

On Wed, Sep 03, 2025 at 02:47:10PM +0200, Benoît Monin wrote:
>  patternProperties:
>    '-pins?$':
> @@ -265,6 +279,88 @@ required:
>  additionalProperties: false
>  
>  allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - mobileye,eyeq5-olb
> +              - mobileye,eyeq6l-olb
> +              - mobileye,eyeq6h-acc-olb
> +              - mobileye,eyeq6h-central-olb
> +              - mobileye,eyeq6h-east-olb
> +              - mobileye,eyeq6h-west-olb
> +              - mobileye,eyeq6h-south-olb
> +              - mobileye,eyeq6h-ddr0-olb
> +              - mobileye,eyeq6h-ddr1-olb
> +              - mobileye,eyeq7h-south-olb
> +              - mobileye,eyeq7h-periph-east-olb
> +              - mobileye,eyeq7h-ddr0-olb
> +              - mobileye,eyeq7h-ddr1-olb
> +              - mobileye,eyeq7h-mips0-olb
> +              - mobileye,eyeq7h-mips1-olb
> +              - mobileye,eyeq7h-mips2-olb
> +    then:
> +      properties:
> +        clocks:
> +          minItems: 1

Drop

> +          maxItems: 1
> +        clock-names:
> +          items:
> +            - const: ref
> +
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - mobileye,eyeq7h-east-olb
> +              - mobileye,eyeq7h-west-olb
> +    then:
> +      properties:
> +        clocks:
> +          minItems: 2
> +          maxItems: 2
> +        clock-names:
> +          items:
> +            - const: ref
> +            - const: ref_100p0
> +
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - mobileye,eyeq7h-periph-west-olb
> +    then:
> +      properties:
> +        clocks:
> +          minItems: 2
> +          maxItems: 2
> +        clock-names:
> +          items:
> +            - const: ref_100p0
> +            - const: ref_106p6_w
> +
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - mobileye,eyeq7h-acc0-olb
> +              - mobileye,eyeq7h-acc1-olb
> +              - mobileye,eyeq7h-xnn0-olb
> +              - mobileye,eyeq7h-xnn1-olb
> +    then:
> +      properties:
> +        clocks:
> +          minItems: 2
> +          maxItems: 2
> +        clock-names:
> +          items:
> +            - const: ref_100p0
> +            - const: ref_106p6_e

That's the same as previous ref_106p6_w.

These are not names of clocks. These are names of inputs.


> +
>      # Compatibles exposing a single reset domain.
>    - if:
>        properties:
> @@ -274,6 +370,12 @@ allOf:
>                - mobileye,eyeq6h-acc-olb
>                - mobileye,eyeq6h-east-olb
>                - mobileye,eyeq6h-west-olb
> +              - mobileye,eyeq7h-east-olb
> +              - mobileye,eyeq7h-west-olb
> +              - mobileye,eyeq7h-periph-east-olb
> +              - mobileye,eyeq7h-periph-west-olb
> +              - mobileye,eyeq7h-ddr0-olb
> +              - mobileye,eyeq7h-ddr1-olb
>      then:
>        properties:
>          '#reset-cells':
> @@ -289,6 +391,11 @@ allOf:
>              enum:
>                - mobileye,eyeq5-olb
>                - mobileye,eyeq6l-olb
> +              - mobileye,eyeq7h-south-olb
> +              - mobileye,eyeq7h-acc0-olb
> +              - mobileye,eyeq7h-acc1-olb
> +              - mobileye,eyeq7h-xnn0-olb
> +              - mobileye,eyeq7h-xnn1-olb
>      then:
>        properties:
>          '#reset-cells':
> @@ -306,6 +413,9 @@ allOf:
>                - mobileye,eyeq6h-south-olb
>                - mobileye,eyeq6h-ddr0-olb
>                - mobileye,eyeq6h-ddr1-olb
> +              - mobileye,eyeq7h-mips0-olb
> +              - mobileye,eyeq7h-mips1-olb
> +              - mobileye,eyeq7h-mips2-olb
>      then:
>        properties:
>          '#reset-cells': false
> @@ -350,3 +460,18 @@ examples:
>          clock-names = "ref";
>        };
>      };
> +  - |
> +    soc {
> +      #address-cells = <2>;
> +      #size-cells = <2>;
> +
> +      system-controller0@...00000 {
> +        compatible = "mobileye,eyeq7h-acc0-olb", "syscon";

No need for new example for difference in one property.

Best regards,
Krzysztof