linux-kernel - Re: [PATCH v6 1/2] dt-bindings: clock: add TI CDCE6214 binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c7fefb2-9a0c-451f-84f6-dc5a19707699@kernel.org>
Date: Thu, 4 Sep 2025 11:43:53 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Sascha Hauer <s.hauer@...gutronix.de>
Cc: Michael Turquette <mturquette@...libre.com>,
 Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-clk@...r.kernel.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 kernel@...gutronix.de, Linus Walleij <linus.walleij@...aro.org>,
 linux-gpio@...r.kernel.org, Alvin Šipraga
 <alsi@...g-olufsen.dk>
Subject: Re: [PATCH v6 1/2] dt-bindings: clock: add TI CDCE6214 binding

On 04/09/2025 09:34, Sascha Hauer wrote:
> On Thu, Sep 04, 2025 at 09:18:13AM +0200, Krzysztof Kozlowski wrote:
>> On Wed, Sep 03, 2025 at 03:55:45PM +0200, Sascha Hauer wrote:
>>> Add device tree binding for the CDCE6214, an Ultra-Low Power Clock
>>> Generator With One PLL, Four Differential Outputs, Two Inputs, and
>>> Internal EEPROM.
>>>
>>> Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>
>>> ---
>>>  .../devicetree/bindings/clock/ti,cdce6214.yaml     | 198 +++++++++++++++++++++
>>>  include/dt-bindings/clock/ti,cdce6214.h            |  24 +++
>>>  2 files changed, 222 insertions(+)
>>>
>>
>> I don't understand what is happening here.
>>
>> Patch changed in weird and unexplained way - nothing in the changelog
>> explains dropping SPDX - and does not pass even checkpatch.
> 
> I removed the SPDX by accident, will add it back of course.
> 
> Other than that, what's weird? Changelog says I now use the pinctrl
> subsystem to configure pins. OK, that also changes the binding, I could
> have mentioned that explicitly, sorry for that.

There were four patches before, now there are two and changelog says
only about pinctrl to configure pins. That's very vague and you expect
me to decipher what changed in the bindings.

Best regards,
Krzysztof