linux-kernel - Re: [PATCH v2 5/5] usb: typec: Expose alternate mode priority via sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMMMRMf1g+EwYfRmygCYiJGJd_XEeHrt-jrQaqKk1_SPyoRhXg@mail.gmail.com>
Date: Fri, 5 Sep 2025 14:22:39 +0200
From: Andrei Kuchynski <akuchynski@...omium.org>
To: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc: Abhishek Pandit-Subedi <abhishekpandit@...omium.org>, Benson Leung <bleung@...omium.org>, 
	Jameson Thies <jthies@...gle.com>, Tzung-Bi Shih <tzungbi@...nel.org>, linux-usb@...r.kernel.org, 
	chrome-platform@...ts.linux.dev, Guenter Roeck <groeck@...omium.org>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>, "Christian A. Ehrhardt" <lk@...e.de>, 
	Venkat Jayaraman <venkat.jayaraman@...el.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 5/5] usb: typec: Expose alternate mode priority via sysfs

On Fri, Sep 5, 2025 at 12:34 PM Heikki Krogerus
<heikki.krogerus@...ux.intel.com> wrote:
>
> On Mon, Aug 25, 2025 at 02:57:50PM +0000, Andrei Kuchynski wrote:
> > This patch introduces a priority sysfs attribute to the USB Type-C
> > alternate mode port interface. This new attribute allows user-space to
> > configure the numeric priority of alternate modes managing their preferred
> > order of operation.
> >
> > Signed-off-by: Andrei Kuchynski <akuchynski@...omium.org>
> > ---
> >  Documentation/ABI/testing/sysfs-class-typec | 11 +++++++
> >  drivers/usb/typec/class.c                   | 32 ++++++++++++++++++++-
>
> Maybe patch 4/5 could be squashed into this patch, and I'm wondering
> would it make sense to just keep the typec_mode_set_priority() in this
> file (drivers/usb/typec/class.c).
>
> Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
>
> --
> heikki

You're right, mode_selection.c is quite empty now. However, in the next
series, it will be the only user of the priority variable. So I'd prefer to
keep it there, if you don’t mind.
I think putting it in class.c would create a mess.

Thank you for the review!

Andrei