linux-kernel - Re: [PATCH v2 0/5] USB Type-C alternate mode priorities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMMMRMcYiB8Sb5sjjdH_TcX8b2kGZFcM=r8L_txpZtyBGZt4Gg@mail.gmail.com>
Date: Fri, 5 Sep 2025 14:41:01 +0200
From: Andrei Kuchynski <akuchynski@...omium.org>
To: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc: Abhishek Pandit-Subedi <abhishekpandit@...omium.org>, Benson Leung <bleung@...omium.org>, 
	Jameson Thies <jthies@...gle.com>, Tzung-Bi Shih <tzungbi@...nel.org>, linux-usb@...r.kernel.org, 
	chrome-platform@...ts.linux.dev, Guenter Roeck <groeck@...omium.org>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>, "Christian A. Ehrhardt" <lk@...e.de>, 
	Venkat Jayaraman <venkat.jayaraman@...el.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/5] USB Type-C alternate mode priorities

On Fri, Sep 5, 2025 at 1:57 PM Heikki Krogerus
<heikki.krogerus@...ux.intel.com> wrote:
>
> Hi Andrei,
>
> On Mon, Aug 25, 2025 at 02:57:45PM +0000, Andrei Kuchynski wrote:
> > This patch series introduces a mechanism for setting USB Type-C alternate
> > mode priorities. It allows the user to specify their preferred order for
> > mode selection, such as USB4, Thunderbolt, or DisplayPort.
> >
> > A new sysfs attribute named 'priority' is exposed to provide user-space
> > control over the mode selection process.
> >
> > This series was tested on a Android OS device running kernel 6.16.
> >
> > Changes in v2:
> > - The priority variable is now a member of the typec_altmode struct
> > - typec_altmode2port is used to obtain the typec_port struct pointer
> > - Default priorities are now set based on the order of registration
> > - The mode_control capability is enabled by default
> > - The mode_selection_state struct will be introduced in a separate series
> > - svid will be used instead of the typec_mode_type enum
> >
> > Andrei Kuchynski (5):
> >   usb: typec: Add alt_mode_override field to port property
> >   platform/chrome: cros_ec_typec: Set alt_mode_override flag
> >   usb: typec: ucsi: Set alt_mode_override flag
> >   usb: typec: Implement alternate mode priority handling
> >   usb: typec: Expose alternate mode priority via sysfs
>
> I'm sorry for keeping you waiting. I think these are okay - although,
> I had to put a few nitpicks :) but they are minor - but can you
> include a patch where you use the priority member in a driver (maybe
> cros_ec_typec.c)?
>
> thanks,
>
> --
> heikki

Thank you for your review and feedback! I appreciate you taking the time to
provide these notes.

The patch using the priority member is part of a subsequent series that I
have ready. I will send it shortly. This functionality is implemented in
mode_selection.c to determine the mode order, and we plan to use it for
both the cros_ec_typec and UCSI implementations.

I will send a new v3 patch set shortly with the minor changes you suggested.

Thanks!
Andrei