linux-kernel - Re: [PATCH v5 2/9] iio: imu: inv_icm45600: add new inv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vdi3W5VRfcEi8SOyTT-490_stCTXiKK0RYrgLpJW2JJgw@mail.gmail.com>
Date: Fri, 5 Sep 2025 16:47:35 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Remi Buisson <Remi.Buisson@....com>
Cc: Andy Shevchenko <andriy.shevchenko@...el.com>, Jonathan Cameron <jic23@...nel.org>, 
	David Lechner <dlechner@...libre.com>, Nuno Sá <nuno.sa@...log.com>, 
	Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>, 
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v5 2/9] iio: imu: inv_icm45600: add new inv_icm45600 driver

On Fri, Sep 5, 2025 at 3:43 PM Remi Buisson <Remi.Buisson@....com> wrote:
> >From: Andy Shevchenko <andriy.shevchenko@...el.com>
> >Sent: Thursday, September 4, 2025 3:17 PM
> >On Thu, Sep 04, 2025 at 12:58:10PM +0000, Remi Buisson wrote:
> >> >From: Andy Shevchenko <andriy.shevchenko@...el.com>
> >> >Sent: Thursday, August 21, 2025 11:03 AM
> >> >On Wed, Aug 20, 2025 at 02:24:20PM +0000, Remi Buisson via B4 Relay wrote:

...

> >> >> + /* Wait a little for supply ramp. */
> >> >> + fsleep(3000);
> >> >
> >> >As per above.
> >> Yes.
> >
> >For both cases actually you can leave a comment, but rewrite it in a way that
> >it refers to the datasheet. This will be useful.
> Ok, I'll do it when the delay is actually documented.
> Unfortunately some of them are missing from the released doc.

Then it's good to add something like "this value is empirically chosen
as datasheet doesn't describe it". Or find better as you know more on
the cases.

-- 
With Best Regards,
Andy Shevchenko