linux-kernel - Re: [PATCH v5 3/9] iio: imu: inv_icm45600: add buffer support in iio devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VcLo__aS1GJCN_zgd5PgNKgtSGbCWbY07qngEFVXBtQVA@mail.gmail.com>
Date: Fri, 5 Sep 2025 16:49:52 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Remi Buisson <Remi.Buisson@....com>
Cc: Andy Shevchenko <andriy.shevchenko@...el.com>, Jonathan Cameron <jic23@...nel.org>, 
	David Lechner <dlechner@...libre.com>, Nuno Sá <nuno.sa@...log.com>, 
	Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>, 
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v5 3/9] iio: imu: inv_icm45600: add buffer support in iio devices

On Fri, Sep 5, 2025 at 3:44 PM Remi Buisson <Remi.Buisson@....com> wrote:
> >From: Andy Shevchenko <andriy.shevchenko@...el.com>
> >Sent: Thursday, September 4, 2025 3:49 PM
> >On Thu, Sep 04, 2025 at 01:01:32PM +0000, Remi Buisson wrote:
> >> >From: Andy Shevchenko <andriy.shevchenko@...el.com>
> >> >Sent: Thursday, August 21, 2025 11:21 AM
> >> >On Wed, Aug 20, 2025 at 02:24:21PM +0000, Remi Buisson via B4 Relay wrote:

...

> >> >> + /* Disable FIFO and set depth. */
> >> >> + val = FIELD_PREP(INV_ICM45600_FIFO_CONFIG0_MODE_MASK,
> >> >> +                  INV_ICM45600_FIFO_CONFIG0_MODE_BYPASS);
> >> >> + val |= INV_ICM45600_FIFO_CONFIG0_FIFO_DEPTH_MAX;
> >> >
> >> >FIELD_MODIFY()
> >> Ok, great.
> >
> >Actually this is not a modification per se, it's just an assignment (PREP)
> >split to two lines, can you just make it a single expression (wrapped on a few
> >lines, though)?
> >
> You mean droping the FIELD_MODIFY suggestion and doing something like:
> val = FIELD_PREP(INV_ICM45600_FIFO_CONFIG0_MODE_MASK,
>                  INV_ICM45600_FIFO_CONFIG0_MODE_BYPASS) |
>          FIELD_PREP(INV_ICM45600_FIFO_CONFIG0_FIFO_DEPTH_MASK,
>                  INV_ICM45600_FIFO_CONFIG0_FIFO_DEPTH_MAX);

Yes.

-- 
With Best Regards,
Andy Shevchenko