linux-kernel - Re: [PATCH v5 2/9] iio: imu: inv_icm45600: add new inv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250907143118.42612bd3@jic23-huawei>
Date: Sun, 7 Sep 2025 14:31:18 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Remi Buisson <Remi.Buisson@....com>
Cc: Remi Buisson via B4 Relay <devnull+remi.buisson.tdk.com@...nel.org>,
 David Lechner <dlechner@...libre.com>, Nuno Sá
 <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>, "linux-iio@...r.kernel.org"
 <linux-iio@...r.kernel.org>, "devicetree@...r.kernel.org"
 <devicetree@...r.kernel.org>
Subject: Re: [PATCH v5 2/9] iio: imu: inv_icm45600: add new inv_icm45600
 driver

On Thu, 4 Sep 2025 13:04:37 +0000
Remi Buisson <Remi.Buisson@....com> wrote:

> >
> >
> >From: Jonathan Cameron <jic23@...nel.org> 
> >Sent: Monday, August 25, 2025 12:35 PM
> >To: Remi Buisson via B4 Relay <devnull+remi.buisson.tdk.com@...nel.org>
> >Cc: Remi Buisson <Remi.Buisson@....com>; David Lechner <dlechner@...libre.com>; Nuno Sá <nuno.sa@...log.com>; Andy Shevchenko <andy@...nel.org>; Rob Herring <robh@...nel.org>; Krzysztof Kozlowski <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>; linux-kernel@...r.kernel.org; linux-iio@...r.kernel.org; devicetree@...r.kernel.org
> >Subject: Re: [PATCH v5 2/9] iio: imu: inv_icm45600: add new inv_icm45600 driver
> >
> >On Wed, 20 Aug 2025 14:24:20 +0000
> >Remi Buisson via B4 Relay <devnull+remi.buisson.tdk.com@...nel.org> wrote:
> >  
> >> From: Remi Buisson <remi.buisson@....com>
> >> 
> >> Core component of a new driver for InvenSense ICM-45600 devices.
> >> It includes registers definition, main probe/setup, and device
> >> utility functions.
> >> 
> >> ICM-456xx devices are latest generation of 6-axis IMU,
> >> gyroscope+accelerometer and temperature sensor. This device
> >> includes a 8K FIFO, supports I2C/I3C/SPI, and provides
> >> intelligent motion features like pedometer, tilt detection,
> >> and tap detection.
> >> 
> >> Signed-off-by: Remi Buisson <remi.buisson@....com>  
> >Hi Remi,
> >
> >A few additional comments from me.  I tried to avoid duplicating
> >anything Andy pointed out, but might have done so a few times.
> >
> >Main comment in here is to take a look at the inline comments
> >and perhaps simplify or remove them if the code that follows
> >is basically self documenting.  Sometimes the comment can be
> >more confusing than the code!
> >
> >Jonathan
> >  
> Warm thanks for the time you spent reviewing comments.
> I tried to clean them following your advices.
> I hope it will improve.

One process comment.  If you agree with a review comment and there
is nothing else to add, just crop it out of your reply.

Focus on the places where more discussion is needed.
If there is none of that don't reply to the review - just add the
changes made to the changelog for the next version of the series.

Jonathan