linux-kernel - Re: [PATCH v5 3/9] iio: imu: inv_icm45600: add buffer support in iio devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250907143411.043fa23f@jic23-huawei>
Date: Sun, 7 Sep 2025 14:34:11 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Remi Buisson <Remi.Buisson@....com>
Cc: Andy Shevchenko <andriy.shevchenko@...el.com>, Alexandre Belloni
 <alexandre.belloni@...tlin.com>, Frank Li <Frank.Li@....com>, David Lechner
 <dlechner@...libre.com>, Nuno Sá <nuno.sa@...log.com>, Andy
 Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v5 3/9] iio: imu: inv_icm45600: add buffer support in
 iio devices


> >  
> >> >> +#define INV_ICM45600_SENSOR_CONF_KEEP_VALUES {U8_MAX, U8_MAX, U8_MAX, U8_MAX, }  
> >> >
> >> >When one line, no need to have inner trailing comma, besides that missed
> >> >space.  
> >> The trailing comma was a request from Jonathan Cameron on the v2 of patchset.
> >> Let me know, if you disagree with him and I'll fix.  
> >
> >I see, then let's ask him, because it's a usual pattern for
> >the one-line arrays like this to have no inner trailing commas.  
> Ok let's wait Jonathan Cameron's feedback.

Definitely ignore me on this.  For one line arrays any change means that
line changes anyway so, unlike multiline arrays there is no reduction in noise
by having the trailing comma.