linux-kernel - Re: [PATCH] iio: proximity: mb1232: use stack allocated scan struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250907142925.6008a5cc@jic23-huawei>
Date: Sun, 7 Sep 2025 14:29:25 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: David Lechner <dlechner@...libre.com>
Cc: Andreas Klinger <ak@...klinger.de>, Nuno Sá
 <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: proximity: mb1232: use stack allocated scan struct

On Fri, 5 Sep 2025 14:12:49 -0500
David Lechner <dlechner@...libre.com> wrote:

> On 7/24/25 5:26 AM, Jonathan Cameron wrote:
> > On Tue, 22 Jul 2025 17:39:17 -0500
> > David Lechner <dlechner@...libre.com> wrote:
> >   
> >> Use a stack allocated struct for the scan data instead of using the
> >> driver state to store the struct. The scan data is not used outside of
> >> the interrupt handler function so the struct does not need to exist
> >> outside of that scope.
> >>
> >> Signed-off-by: David Lechner <dlechner@...libre.com>  
> > Hi David,
> > 
> > Applied to the testing branch of iio.git.
> > 
> > I don't suppose you fancy a follow up to take that irqnr local to probe?
> > If not I'll get to it at some point maybe.
> >   
> It is also used in mb1232_read_distance(), so this wouldn't be trivial.

Ah. I'd missed that.  Agreed that it doesn't makes sense to make it
local.

J