[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250905062157.s32xwnyfbphyupfa@lcpd911>
Date: Fri, 5 Sep 2025 11:51:57 +0530
From: Dhruva Gole <d-gole@...com>
To: Akashdeep Kaur <a-kaur@...com>
CC: <praneeth@...com>, <nm@...com>, <afd@...com>, <vigneshr@...com>,
<u-kumar1@...com>, <sebin.francis@...com>, <kristo@...nel.org>,
<robh@...nel.org>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
<linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <vishalm@...com>
Subject: Re: [PATCH v5 4/4] arm64: dts: ti: k3-pinctrl: Fix the bug in
existing macros
On Sep 05, 2025 at 10:44:48 +0530, Akashdeep Kaur wrote:
> Currently, DS_IO_OVERRIDE_EN_SHIFT macro is not defined anywhere but
> used for defining other macro.
> Replace this undefined macro with valid macro. Rename the existing macro
> to reflect the actual behavior.
>
> Signed-off-by: Akashdeep Kaur <a-kaur@...com>
> ---
> arch/arm64/boot/dts/ti/k3-pinctrl.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-pinctrl.h b/arch/arm64/boot/dts/ti/k3-pinctrl.h
> index 8ce37ace94c9..e46f7bf52701 100644
> --- a/arch/arm64/boot/dts/ti/k3-pinctrl.h
> +++ b/arch/arm64/boot/dts/ti/k3-pinctrl.h
> @@ -88,8 +88,8 @@
>
> #define PIN_DS_FORCE_DISABLE (0 << FORCE_DS_EN_SHIFT)
> #define PIN_DS_FORCE_ENABLE (1 << FORCE_DS_EN_SHIFT)
> -#define PIN_DS_IO_OVERRIDE_DISABLE (0 << DS_IO_OVERRIDE_EN_SHIFT)
> -#define PIN_DS_IO_OVERRIDE_ENABLE (1 << DS_IO_OVERRIDE_EN_SHIFT)
> +#define PIN_DS_ISO_OVERRIDE_DISABLE (0 << ISO_OVERRIDE_EN_SHIFT)
> +#define PIN_DS_ISO_OVERRIDE_ENABLE (1 << ISO_OVERRIDE_EN_SHIFT)
Reviewed-by: Dhruva Gole <d-gole@...com>
--
Best regards,
Dhruva Gole
Texas Instruments Incorporated
Powered by blists - more mailing lists