linux-kernel - Re: [PATCH v2 1/2] i2c: designware: convert to dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38c8816c-408c-4f9f-9c31-84072326f066@linux.intel.com>
Date: Fri, 5 Sep 2025 11:04:22 +0300
From: Jarkko Nikula <jarkko.nikula@...ux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Benoît Monin <benoit.monin@...tlin.com>
Cc: Mika Westerberg <mika.westerberg@...ux.intel.com>,
 Jan Dabros <jsd@...ihalf.com>, Andi Shyti <andi.shyti@...nel.org>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
 Vladimir Kondratiev <vladimir.kondratiev@...ileye.com>,
 Tawfik Bayouk <tawfik.bayouk@...ileye.com>, linux-i2c@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] i2c: designware: convert to dev_err_probe() on
 request IRQ error

On 9/4/25 6:02 PM, Andy Shevchenko wrote:
> On Thu, Sep 04, 2025 at 04:31:06PM +0200, Benoît Monin wrote:
>> Simplify the error handling of devm_request_irq() in
>> i2c_dw_probe_master() and i2c_dw_probe_slave() by converting to:
>>
>>      return dev_err_probe();
>>
>> instead of calling:
>>
>>      dev_err();
>>      return ret;
>>
>> This also handle deferred probe error without spamming the log.
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 
Acked-by: Jarkko Nikula <jarkko.nikula@...ux.intel.com>