linux-kernel - Re: [PATCH v2 2/2] i2c: designware: use dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <61ecd626-1081-4bf0-8db7-a68980f31e45@linux.intel.com>
Date: Fri, 5 Sep 2025 11:04:32 +0300
From: Jarkko Nikula <jarkko.nikula@...ux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Benoît Monin <benoit.monin@...tlin.com>
Cc: Mika Westerberg <mika.westerberg@...ux.intel.com>,
 Jan Dabros <jsd@...ihalf.com>, Andi Shyti <andi.shyti@...nel.org>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
 Vladimir Kondratiev <vladimir.kondratiev@...ileye.com>,
 Tawfik Bayouk <tawfik.bayouk@...ileye.com>, linux-i2c@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] i2c: designware: use dev_err_probe() when probing
 platform device

On 9/4/25 6:04 PM, Andy Shevchenko wrote:
> On Thu, Sep 04, 2025 at 04:31:07PM +0200, Benoît Monin wrote:
>> Add calls to dev_err_probe() on error paths that can return
>> -EPROBE_DEFER when probing platform device. Namely when requesting the
>> reset controller, when probing for lock support and when requesting the
>> clocks.
>>
>> PCI device probing already use dev_err_probe().
> 
> Makes sense by at least two aspects:
> 1) less log spamming for deferred probes;
> 2) easier to debug an issue (I assume it's your case).
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 
Acked-by: Jarkko Nikula <jarkko.nikula@...ux.intel.com>