linux-kernel - Re: [PATCH v1 2/4] dt-bindings: clock: rk3368: add CLK_I2S_8CH_PRE and CLK_I2S_8CH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58b638c8-b27e-49a6-b79e-f078135c575b@kernel.org>
Date: Sat, 6 Sep 2025 09:21:30 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: 李维豪 <cn.liweihao@...il.com>
Cc: heiko@...ech.de, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH v1 2/4] dt-bindings: clock: rk3368: add CLK_I2S_8CH_PRE
 and CLK_I2S_8CH_FRAC

On 06/09/2025 03:34, 李维豪 wrote:
> Hi,
> 
> Krzysztof Kozlowski <krzk@...nel.org> 于2025年9月5日周五 22:13写道：
>>
>> On 05/09/2025 15:23, WeiHao Li wrote:
>>> We need a clock id to assign clock parent when use i2s 8ch as audio
>>> device, CLK_I2S_8CH_FRAC should be CLK_I2S_8CH_PRE parent so we can get
>>> frequency we want.
>>>
>>> Signed-off-by: WeiHao Li <cn.liweihao@...il.com>
>>> ---
>>>  include/dt-bindings/clock/rk3368-cru.h | 3 +++
>>>  1 file changed, 3 insertions(+)
>>>
>>> diff --git a/include/dt-bindings/clock/rk3368-cru.h b/include/dt-bindings/clock/rk3368-cru.h
>>> index b951e29069..795e721957 100644
>>> --- a/include/dt-bindings/clock/rk3368-cru.h
>>> +++ b/include/dt-bindings/clock/rk3368-cru.h
>>> @@ -183,6 +183,9 @@
>>>  #define HCLK_BUS             477
>>>  #define HCLK_PERI            478
>>>
>>> +#define CLK_I2S_8CH_PRE              500
>>
>> 479
>>
>>> +#define CLK_I2S_8CH_FRAC     501
>>
>> 480, no?
>>
> 
> Neither of these clocks belong to the previous grouping in terms of
> type, so I chose to start with a new integer id here.

I don't know what is "previous grouping" here, but IDs are abstract and
are incremented by 1.

Best regards,
Krzysztof