linux-kernel - Re: [PATCH v1 2/4] dt-bindings: clock: rk3368: add CLK_I2S_8CH_PRE and CLK_I2S_8CH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DCLRQQH0F49Q.2OUP59P4VV91O@cknow.org>
Date: Sat, 06 Sep 2025 15:57:55 +0200
From: "Diederik de Haas" <didi.debian@...ow.org>
To: 李维豪 <cn.liweihao@...il.com>,
 "Krzysztof Kozlowski" <krzk@...nel.org>
Cc: <heiko@...ech.de>, <robh@...nel.org>, <krzk+dt@...nel.org>,
 <conor+dt@...nel.org>, <devicetree@...r.kernel.org>,
 <linux-arm-kernel@...ts.infradead.org>,
 <linux-rockchip@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
 <linux-clk@...r.kernel.org>
Subject: Re: [PATCH v1 2/4] dt-bindings: clock: rk3368: add CLK_I2S_8CH_PRE
 and CLK_I2S_8CH_FRAC

On Sat Sep 6, 2025 at 3:34 PM CEST, 李维豪 wrote:
> Krzysztof Kozlowski <krzk@...nel.org> 于2025年9月6日周六 15:21写道：
>> On 06/09/2025 03:34, 李维豪 wrote:
>> > Krzysztof Kozlowski <krzk@...nel.org> 于2025年9月5日周五 22:13写道：
>> >> On 05/09/2025 15:23, WeiHao Li wrote:
>> >>> We need a clock id to assign clock parent when use i2s 8ch as audio
>> >>> device, CLK_I2S_8CH_FRAC should be CLK_I2S_8CH_PRE parent so we can get
>> >>> frequency we want.
>> >>>
>> >>> Signed-off-by: WeiHao Li <cn.liweihao@...il.com>
>> >>> ---
>> >>>  include/dt-bindings/clock/rk3368-cru.h | 3 +++
>> >>>  1 file changed, 3 insertions(+)
>> >>>
>> >>> diff --git a/include/dt-bindings/clock/rk3368-cru.h b/include/dt-bindings/clock/rk3368-cru.h
>> >>> index b951e29069..795e721957 100644
>> >>> --- a/include/dt-bindings/clock/rk3368-cru.h
>> >>> +++ b/include/dt-bindings/clock/rk3368-cru.h
>> >>> @@ -183,6 +183,9 @@
>> >>>  #define HCLK_BUS             477
>> >>>  #define HCLK_PERI            478
>> >>>
>> >>> +#define CLK_I2S_8CH_PRE              500
>> >>
>> >> 479
>> >>
>> >>> +#define CLK_I2S_8CH_FRAC     501
>> >>
>> >> 480, no?
>> >>
>> >
>> > Neither of these clocks belong to the previous grouping in terms of
>> > type, so I chose to start with a new integer id here.
>>
>> I don't know what is "previous grouping" here, but IDs are abstract and
>> are incremented by 1.
>
> In the current kernel code, the RK3368 clock IDs are categorized by
> SCLK, ACLK, PCLK, and HCLK.

Maybe this helps understanding the discrepancy:

Starting with the rk3588 series, clock IDs are in the 'clock' binding
dir and named "rockchip,rk<SoC-id>-cru.h" and are numbered sequentially
with no gaps. And the reset IDs are in the 'reset' binding dir with the
same filename pattern.

With older SoC series, including rk3568*, both the clock and reset IDs
are in "clock/rk<SoC-id>-cru.h" where they are NOT sequentially
numbered and thus jumps in the numbering is not out of place there.

HTH,
  Diederik

*) I have a local commit which moves the reset IDs to
"reset/rockchip,rk3568-cru.h", but I don't know how to do/fix the
numbering, so I never submitted it.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)