linux-kernel - Re: [PATCH] PM / devfreq: mtk-cci: avoid redundant conditions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGTfZH2ch56uca-x7TLTYu3Q0q-j+1nCsSOjUV0R7XQ3XLQ7CA@mail.gmail.com>
Date: Sun, 7 Sep 2025 10:34:16 +0900
From: Chanwoo Choi <chanwoo@...nel.org>
To: Liao Yuanhong <liaoyuanhong@...o.com>
Cc: MyungJoo Ham <myungjoo.ham@...sung.com>, Kyungmin Park <kyungmin.park@...sung.com>, 
	Chanwoo Choi <cw00.choi@...sung.com>, Matthias Brugger <matthias.bgg@...il.com>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, 
	"open list:DEVICE FREQUENCY (DEVFREQ)" <linux-pm@...r.kernel.org>, 
	"open list:ARM/Mediatek SoC support" <linux-kernel@...r.kernel.org>, 
	"moderated list:ARM/Mediatek SoC support" <linux-arm-kernel@...ts.infradead.org>, 
	"moderated list:ARM/Mediatek SoC support" <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH] PM / devfreq: mtk-cci: avoid redundant conditions

Hi,

Applied it.

Thanks.

On Wed, Sep 3, 2025 at 9:15 PM Liao Yuanhong <liaoyuanhong@...o.com> wrote:
>
> While 'if (i <= 0) ... else if (i > 0) ...' is technically equivalent to
> 'if (i <= 0) ... else ...', the latter is vastly easier to read because
> it avoids writing out a condition that is unnecessary. Let's drop such
> unnecessary conditions.
>
> Signed-off-by: Liao Yuanhong <liaoyuanhong@...o.com>
> ---
>  drivers/devfreq/mtk-cci-devfreq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/devfreq/mtk-cci-devfreq.c b/drivers/devfreq/mtk-cci-devfreq.c
> index 22fe9e631f8a..693c59c8037a 100644
> --- a/drivers/devfreq/mtk-cci-devfreq.c
> +++ b/drivers/devfreq/mtk-cci-devfreq.c
> @@ -86,7 +86,7 @@ static int mtk_ccifreq_set_voltage(struct mtk_ccifreq_drv *drv, int new_voltage)
>                                                       soc_data->sram_max_volt);
>                                 return ret;
>                         }
> -               } else if (pre_voltage > new_voltage) {
> +               } else {
>                         voltage = max(new_voltage,
>                                       pre_vsram - soc_data->max_volt_shift);
>                         ret = regulator_set_voltage(drv->proc_reg, voltage,
> --
> 2.34.1
>
>


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics