linux-kernel - Re: [PATCH v1 6/7] hwmon: sl28cpld: add SMARC-sAM67 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <83189bf7-6831-4373-a352-2a3a05526e08@roeck-us.net>
Date: Sun, 7 Sep 2025 08:28:19 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Michael Walle <mwalle@...nel.org>, Nishanth Menon <nm@...com>,
 Vignesh Raghavendra <vigneshr@...com>, Tero Kristo <kristo@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Jean Delvare <jdelvare@...e.com>,
 Lee Jones <lee@...nel.org>, Srinivas Kandagatla <srini@...nel.org>,
 Wim Van Sebroeck <wim@...ux-watchdog.org>
Cc: linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org,
 linux-watchdog@...r.kernel.org
Subject: Re: [PATCH v1 6/7] hwmon: sl28cpld: add SMARC-sAM67 support

On 8/22/25 06:15, Michael Walle wrote:
> The on-board uC on the SMARC-sAM67 board is compatible with the older
> CPLD implementation on the SMARC-sAL28 board, but has different sensors,
> namely two voltage sensors and one temperature sensor. Add support for it.
> 
> Signed-off-by: Michael Walle <mwalle@...nel.org>
> ---
>   drivers/hwmon/sl28cpld-hwmon.c | 76 ++++++++++++++++++++++++++++++++--

Documentation/hwmon/sl28cpld.rst would have to be updated as well.

...

>   static const struct of_device_id sl28cpld_hwmon_of_match[] = {
> -	{ .compatible = "kontron,sl28cpld-fan" },
> +	{ .compatible = "kontron,sl28cpld-fan", .data = &sl28cpld_hwmon_chip_info },
> +	{ .compatible = "kontron,sa67mcu-hwmon", .data = &sa67mcu_hwmon_chip_info },

Effectively this means that the two chips have completely different functionality.
One reports fan speeds, the other reports voltages and current.
This should be a separate driver.

Guenter