linux-kernel - Re: [PATCH v1 6/7] hwmon: sl28cpld: add SMARC-sAM67 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DCN86WR0CPF1.38V3X1O08VYJG@kernel.org>
Date: Mon, 08 Sep 2025 09:04:00 +0200
From: "Michael Walle" <mwalle@...nel.org>
To: "Guenter Roeck" <linux@...ck-us.net>, "Nishanth Menon" <nm@...com>,
 "Vignesh Raghavendra" <vigneshr@...com>, "Tero Kristo" <kristo@...nel.org>,
 "Rob Herring" <robh@...nel.org>, "Krzysztof Kozlowski"
 <krzk+dt@...nel.org>, "Conor Dooley" <conor+dt@...nel.org>, "Jean Delvare"
 <jdelvare@...e.com>, "Lee Jones" <lee@...nel.org>, "Srinivas Kandagatla"
 <srini@...nel.org>, "Wim Van Sebroeck" <wim@...ux-watchdog.org>
Cc: <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <linux-hwmon@...r.kernel.org>,
 <linux-watchdog@...r.kernel.org>
Subject: Re: [PATCH v1 6/7] hwmon: sl28cpld: add SMARC-sAM67 support

Hi Guenter,

> >   static const struct of_device_id sl28cpld_hwmon_of_match[] = {
> > -	{ .compatible = "kontron,sl28cpld-fan" },
> > +	{ .compatible = "kontron,sl28cpld-fan", .data = &sl28cpld_hwmon_chip_info },
> > +	{ .compatible = "kontron,sa67mcu-hwmon", .data = &sa67mcu_hwmon_chip_info },
>
> Effectively this means that the two chips have completely different functionality.
> One reports fan speeds, the other reports voltages and current.
> This should be a separate driver.

Fair enough. I wasn't sure, the reason why I've chosen to add it to
the sl28cpld driver was that I don't want to clutter the directory
with many small board specific drivers. They all have the simple-mfd
parent driver in common. In the end it's up to you of course, so
separate driver?

-michael

Download attachment "signature.asc" of type "application/pgp-signature" (298 bytes)