[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87segx256a.wl-kuninori.morimoto.gx@renesas.com>
Date: Sun, 7 Sep 2025 23:50:40 +0000
From: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To: chenyuan_fl@....com
Cc: geert+renesas@...der.be,
mturquette@...libre.com,
sboyd@...nel.org,
linux-renesas-soc@...r.kernel.org,
linux-clk@...r.kernel.org,
linux-kernel@...r.kernel.org,
Yuan CHen <chenyuan@...inos.cn>
Subject: Re: [PATCH] clk: renesas: fix memory leak in cpg_mssr_reserved_init()
Hi chenyuan
Thank you for your patch
> In the current implementation, when krealloc_array() fails, the original memory
> pointer is incorrectly set to NULL after kfree(), resulting in a memory leak
> during reallocation failure.
>
> Fixes: 6aa17547649 ("clk: renesas: cpg-mssr: Ignore all clocks assigned to non-Linux system")
> Signed-off-by: Yuan CHen <chenyuan@...inos.cn>
Basically, I can agree that current code has memory leak issue.
But what does "the original memory pointer is incorrectly set to NULL after
kfree()," mean ? I guess git-log needs update ?
Thank you for your help !!
Best regards
---
Kuninori Morimoto
Powered by blists - more mailing lists