linux-kernel - Re: [PATCH v2] PCI: mvebu: Fix use of for_each_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJaLiFwwTaok1JLTz=JCEhVacvL=ZB4X8TBDwR0NfhHrBp3YKg@mail.gmail.com>
Date: Sun, 7 Sep 2025 16:53:24 -0700
From: Tony Dinh <mibodhi@...il.com>
To: Jan Palus <jpalus@...tmail.com>
Cc: Klaus Kudielka <klaus.kudielka@...il.com>, 
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>, Pali Rohár <pali@...nel.org>, 
	Lorenzo Pieralisi <lpieralisi@...nel.org>, Krzysztof Wilczyński <kwilczynski@...nel.org>, 
	Manivannan Sadhasivam <mani@...nel.org>, Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>, 
	linux-pci@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, Bjorn Helgaas <helgaas@...nel.org>
Subject: Re: [PATCH v2] PCI: mvebu: Fix use of for_each_of_range() iterator

On Sun, Sep 7, 2025 at 4:42 PM Jan Palus <jpalus@...tmail.com> wrote:
>
> On 07.09.2025 12:21, Klaus Kudielka wrote:
> > The blamed commit simplifies code, by using the for_each_of_range()
> > iterator. But it results in no pci devices being detected anymore on
> > Turris Omnia (and probably other mvebu targets).
> >
> > Issue #1:
> >
> > To determine range.flags, of_pci_range_parser_one() uses bus->get_flags(),
> > which resolves to of_bus_pci_get_flags(). That function already returns an
> > IORESOURCE bit field, and NOT the original flags from the "ranges"
> > resource.
> >
> > Then mvebu_get_tgt_attr() attempts the very same conversion again.
> > But this is a misinterpretation of range.flags.
> >
> > Remove the misinterpretation of range.flags in mvebu_get_tgt_attr(),
> > to restore the intended behavior.
> >
> > Issue #2:
> >
> > The driver needs target and attributes, which are encoded in the raw
> > address values of the "/soc/pcie/ranges" resource. According to
> > of_pci_range_parser_one(), the raw values are stored in range.bus_addr
> > and range.parent_bus_addr, respectively. range.cpu_addr is a translated
> > version of range.parent_bus_addr, and not relevant here.
> >
> > Use the correct range structure member, to extract target and attributes.
> > This restores the intended behavior.
> >
> > Signed-off-by: Klaus Kudielka <klaus.kudielka@...il.com>
> > Fixes: 5da3d94a23c6 ("PCI: mvebu: Use for_each_of_range() iterator for parsing "ranges"")
> > Reported-by: Bjorn Helgaas <helgaas@...nel.org>
> > Closes: https://lore.kernel.org/r/20250820184603.GA633069@bhelgaas/
> > Reported-by: Jan Palus <jpalus@...tmail.com>
> > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220479
> > ---
> > v2: Fix issue #2, as well.
> >
> >  drivers/pci/controller/pci-mvebu.c | 21 ++++-----------------
> >  1 file changed, 4 insertions(+), 17 deletions(-)
>
> Confirmed the patch applied on top of 6.16.5 fixes all the issues
> introduced with 5da3d94a23c6.
>
> Tested-by: Jan Palus <jpalus@...tmail.com>
>
Sorry, should have said:

Tested on these Marvell Kirkwood SoC boards: Cloudengine Pogoplug
Series 4 (88F6192), ZyXEL NAS325 (88F6282), and Synology DS112
(88F6282) running kernel 6.16.5.

All the best,
Tony