[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250907103211.0b4b1ff6@jic23-huawei>
Date: Sun, 7 Sep 2025 10:32:11 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: David Lechner <dlechner@...libre.com>
Cc: Martin Tuma <martin.tuma@...iteqautomotive.com>, Mauro Carvalho Chehab
<mchehab@...nel.org>, linux-iio@...r.kernel.org,
linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] media: pci: mg4b: use aligned_s64
On Fri, 05 Sep 2025 14:06:19 -0500
David Lechner <dlechner@...libre.com> wrote:
> Use aligned_s64 for IIO timestamp field instead of explicit __align().
> This is the convention used throughout the IIO subsystem. No functional
> change.
>
> Suggested-by: Jonathan Cameron <jic23@...nel.org>
> Closes: https://lore.kernel.org/linux-iio/20250724115610.011110fb@jic23-huawei/
> Signed-off-by: David Lechner <dlechner@...libre.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@...wei.com>
> ---
> drivers/media/pci/mgb4/mgb4_trigger.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/pci/mgb4/mgb4_trigger.c b/drivers/media/pci/mgb4/mgb4_trigger.c
> index d7dddc5c8728e81c6249b03a4cbf692da15a4ced..bed8bbd4bc595d1d131b9919c6f3b705e43ba3c4 100644
> --- a/drivers/media/pci/mgb4/mgb4_trigger.c
> +++ b/drivers/media/pci/mgb4/mgb4_trigger.c
> @@ -17,6 +17,7 @@
> #include <linux/iio/triggered_buffer.h>
> #include <linux/pci.h>
> #include <linux/dma/amd_xdma.h>
> +#include <linux/types.h>
> #include "mgb4_core.h"
> #include "mgb4_trigger.h"
>
> @@ -90,7 +91,7 @@ static irqreturn_t trigger_handler(int irq, void *p)
> struct trigger_data *st = iio_priv(indio_dev);
> struct {
> u32 data;
> - s64 ts __aligned(8);
> + aligned_s64 ts;
> } scan = { };
>
> scan.data = mgb4_read_reg(&st->mgbdev->video, 0xA0);
>
Powered by blists - more mailing lists