[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250907103246.405d57e6@jic23-huawei>
Date: Sun, 7 Sep 2025 10:32:46 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: David Lechner <dlechner@...libre.com>
Cc: Martin Tuma <martin.tuma@...iteqautomotive.com>, Mauro Carvalho Chehab
<mchehab@...nel.org>, linux-iio@...r.kernel.org,
linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] media: pci: mg4b: use iio_push_to_buffers_with_ts()
On Fri, 05 Sep 2025 14:06:20 -0500
David Lechner <dlechner@...libre.com> wrote:
> Replace iio_push_to_buffers_with_timestamp() with
> iio_push_to_buffers_with_ts(). This adds an extra argument with the
> buffer size to ensure that we aren't writing past the end of the buffer.
> No functional change.
>
> Suggested-by: Jonathan Cameron <jic23@...nel.org>
> Closes: https://lore.kernel.org/linux-iio/20250724115610.011110fb@jic23-huawei/
> Signed-off-by: David Lechner <dlechner@...libre.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@...wei.com>
> ---
> drivers/media/pci/mgb4/mgb4_trigger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/pci/mgb4/mgb4_trigger.c b/drivers/media/pci/mgb4/mgb4_trigger.c
> index bed8bbd4bc595d1d131b9919c6f3b705e43ba3c4..4f9a35904b4186618a554e3047d6b46ff7ed74be 100644
> --- a/drivers/media/pci/mgb4/mgb4_trigger.c
> +++ b/drivers/media/pci/mgb4/mgb4_trigger.c
> @@ -97,7 +97,7 @@ static irqreturn_t trigger_handler(int irq, void *p)
> scan.data = mgb4_read_reg(&st->mgbdev->video, 0xA0);
> mgb4_write_reg(&st->mgbdev->video, 0xA0, scan.data);
>
> - iio_push_to_buffers_with_timestamp(indio_dev, &scan, pf->timestamp);
> + iio_push_to_buffers_with_ts(indio_dev, &scan, sizeof(scan), pf->timestamp);
> iio_trigger_notify_done(indio_dev->trig);
>
> mgb4_write_reg(&st->mgbdev->video, 0xB4, 1U << 11);
>
Powered by blists - more mailing lists