linux-kernel - Re: [PATCH v2 0/5] staging: Destage VCHIQ interface and MMAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250908133527.GE26062@pendragon.ideasonboard.com>
Date: Mon, 8 Sep 2025 15:35:27 +0200
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Jai Luthra <jai.luthra@...asonboard.com>
Cc: Dan Carpenter <dan.carpenter@...aro.org>,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Ray Jui <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>,
	linux-rpi-kernel@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org, kernel-list@...pberrypi.com,
	Stefan Wahren <wahrenst@....net>,
	Dave Stevenson <dave.stevenson@...pberrypi.com>,
	Umang Jain <umang.jain@...asonboard.com>
Subject: Re: [PATCH v2 0/5] staging: Destage VCHIQ interface and MMAL

On Mon, Sep 08, 2025 at 04:45:46PM +0530, Jai Luthra wrote:
> Quoting Dan Carpenter (2025-09-08 11:18:25)
> > It's really hard to review the code when it's just sigle line like
> > this:
> > 
> > >  .../raspberrypi/vchiq-interface}/vchiq_arm.c       |    9 +-
> > 
> > It's also a head ache to do a cat -n filename and then copy and paste
> > it into an email message...  I thought there was a trick to make the
> > diff show up in the email?
> > 
> 
> I am not sure how to configure b4 to give the full file path instead of
> shortening it after the first file in a list.
> 
> Does git-format-patch already have some option? I can use that to ease
> reviews till b4 adds support for this feature.

--stat=-1 should help. I don't know if -1 happens to work or is the
official way to remove the limit. --stat=65535 should be big enough too
:-)

> Or did I misunderstand your problem?

-- 
Regards,

Laurent Pinchart