linux-kernel - Re: [PATCH v2 0/5] staging: Destage VCHIQ interface and MMAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <175733014607.8095.7451233410776368088@freya>
Date: Mon, 08 Sep 2025 16:45:46 +0530
From: Jai Luthra <jai.luthra@...asonboard.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Florian Fainelli <florian.fainelli@...adcom.com>, Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Ray Jui <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>, linux-rpi-kernel@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org, linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org, kernel-list@...pberrypi.com, Stefan Wahren <wahrenst@....net>, Dave Stevenson <dave.stevenson@...pberrypi.com>, Laurent Pinchart <laurent.pinchart@...asonboard.com>, Umang Jain <umang.jain@...asonboard.com>
Subject: Re: [PATCH v2 0/5] staging: Destage VCHIQ interface and MMAL

Hi Dan,

Quoting Dan Carpenter (2025-09-08 11:18:25)
> It's really hard to review the code when it's just sigle line like
> this:
> 
> >  .../raspberrypi/vchiq-interface}/vchiq_arm.c       |    9 +-
> 
> It's also a head ache to do a cat -n filename and then copy and paste
> it into an email message...  I thought there was a trick to make the
> diff show up in the email?
> 

I am not sure how to configure b4 to give the full file path instead of
shortening it after the first file in a list.

Does git-format-patch already have some option? I can use that to ease
reviews till b4 adds support for this feature.

Or did I misunderstand your problem?

> regards,
> dan carpenter
>

Thanks,
    Jai