linux-kernel - Re: [PATCH v3] drm/panel-edp: Add 4 more panels needed by mt8189 Chromebooks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAD=FV=U5CYQ8x7jya6y=eqEY4Zi87unrRTKfexEahVeBXMD5yA@mail.gmail.com>
Date: Mon, 8 Sep 2025 09:00:56 -0700
From: Doug Anderson <dianders@...omium.org>
To: Zhongtian Wu <wuzhongtian@...qin.corp-partner.google.com>
Cc: neil.armstrong@...aro.org, jessica.zhang@....qualcomm.com, 
	maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de, 
	airlied@...il.com, simona@...ll.ch, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] drm/panel-edp: Add 4 more panels needed by mt8189 Chromebooks

Hi,

On Sun, Sep 7, 2025 at 11:37 PM Zhongtian Wu
<wuzhongtian@...qin.corp-partner.google.com> wrote:
>
> Add a few generic edp panels used by mt8189 chromebooks. For
> BOE-NV140WUM-N44 , the enable timing required 80ms. For
> CSW-MNE007QB3-1, the hpd_absent timing rquired 80ms, the enable timing
> required 50ms, the disable timing required 50ms. For CSW-MNE007QS3-6,
> the enable timing required 50ms. For CMN-N140JCA-ELK, the enable timing
> required 80ms and disable timing required 50ms.
>
> BOE NV140WUM-N44 V8.2
> edid-decode (hex):
>
> 00 ff ff ff ff ff ff 00 09 e5 6a 0a 00 00 00 00
> 2e 20 01 04 a5 1e 13 78 03 fb f5 96 5d 5a 91 29
> 1e 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01
> 01 01 01 01 01 01 61 40 80 04 71 b0 3c 40 30 20
> 36 00 2d bc 10 00 00 1a 81 33 80 04 71 b0 3c 40
> 30 20 36 00 2d bc 10 00 00 1a 00 00 00 fd 00 28
> 3c 4c 4c 10 01 0a 20 20 20 20 20 20 00 00 00 fe
> 00 4e 56 31 34 30 57 55 4d 2d 4e 34 34 0a 01 7c
>
> 02 03 0d 00 68 1a 00 00 01 01 28 3c 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 06
>
> CSW MNE007QB3-1:
> edid-decode (hex):
>
> 00 ff ff ff ff ff ff 00 0e 77 6e 14 00 00 00 00
> 00 23 01 04 a5 1e 13 78 07 ee 95 a3 54 4c 99 26
> 0f 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01
> 01 01 01 01 01 01 35 3c 80 a0 70 b0 23 40 30 20
> 36 00 2d bc 10 00 00 18 2b 30 80 a0 70 b0 23 40
> 30 20 36 00 2d bc 10 00 00 18 00 00 00 fd 00 28
> 3c 4a 4a 0f 01 0a 20 20 20 20 20 20 00 00 00 fc
> 00 4d 4e 45 30 30 37 51 42 33 2d 31 0a 20 01 69
>
> 70 20 79 02 00 21 00 1d c8 0b 5d 07 80 07 b0 04
> 00 3d 8a 54 cd a4 99 66 62 0f 02 45 54 40 5e 40
> 5e 00 44 12 78 2e 00 06 00 44 40 5e 40 5e 81 00
> 20 74 1a 00 00 03 01 28 3c 00 00 00 00 00 00 3c
> 00 00 00 00 8d 00 e3 05 04 00 e6 06 01 00 60 60
> ff 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 68 90
>
> CSW MNE007QS3-6:
> edid-decode (hex):
>
> 00 ff ff ff ff ff ff 00 0e 77 3f 14 00 00 00 00
> 00 22 01 04 a5 1e 13 78 03 2c c5 94 5c 59 95 29
> 1e 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01
> 01 01 01 01 01 01 ea 3d 80 c8 70 b0 2e 40 30 20
> 36 00 2e bd 10 00 00 1a 88 31 80 c8 70 b0 2e 40
> 30 20 36 00 2e bd 10 00 00 1a 00 00 00 fd 00 28
> 3c 4b 4b 10 01 0a 20 20 20 20 20 20 00 00 00 fc
> 00 4d 4e 45 30 30 37 51 53 33 2d 36 0a 20 01 80
>
> 70 20 79 02 00 81 00 14 74 1a 00 00 03 01 28 3c
> 00 00 00 00 00 00 3c 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 9e 90
>
> CMN N140JCA-ELK:
> edid-decode (hex):
>
> 00 ff ff ff ff ff ff 00 0d ae 41 14 00 00 00 00
> 25 21 01 04 a5 1e 13 78 03 28 65 97 59 54 8e 27
> 1e 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01
> 01 01 01 01 01 01 42 3c 80 a0 70 b0 24 40 30 20
> a6 00 2d bc 10 00 00 18 35 30 80 a0 70 b0 24 40
> 30 20 a6 00 2d bc 10 00 00 18 00 00 00 fd 00 28
> 3c 4b 4b 10 01 0a 20 20 20 20 20 20 00 00 00 fe
> 00 4e 31 34 30 4a 43 41 2d 45 4c 4b 0a 20 01 14
>
> 02 03 0d 00 68 1a 00 00 01 01 28 3c 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 06
>
> Reviewed-by: Douglas Anderson <dianders@...omium.org>
> Signed-off-by: Zhongtian Wu <wuzhongtian@...qin.corp-partner.google.com>

Note that I hadn't actually provided my Reviewed-by tag on your
previous version, so you shouldn't have included it here. Even if I
responded to the patch, the Reviewed-by tag means that I've happy with
it and I did not provide that on your previous version.

...in this particular case it turns out that I _am_ happy with the
current version, but you should have still let me say that and not
added the tag yourself...

...hmmm, and then I tried to apply your patch and it didn't apply
cleanly. :( Please post your patches for edp-panel against
drm-misc-next. This makes it so I don't need to manually fix things
up... I've fixed it up myself this time, but next time I'll ask you to
send a new version.

In any case, I've gone ahead and pushed it to drm-misc-next:


[1/1] drm/panel-edp: Add 4 more panels needed by mt8189 Chromebooks
      commit: 490b30fbaca2abbd6afa8bdc7e2df329b5d82412