linux-kernel - Re: [PATCH 1/3] crypto: ccp - Use int type to store negative error codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cdd5f593-0ed7-099e-1a72-9a190edbf02c@amd.com>
Date: Mon, 8 Sep 2025 11:00:48 -0500
From: Tom Lendacky <thomas.lendacky@....com>
To: Qianfeng Rong <rongqianfeng@...o.com>, Ashish Kalra
 <ashish.kalra@....com>, John Allen <john.allen@....com>,
 Herbert Xu <herbert@...dor.apana.org.au>,
 "David S. Miller" <davem@...emloft.net>,
 "open list:AMD CRYPTOGRAPHIC COPROCESSOR (CCP) DRIVER - SE..."
 <linux-crypto@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] crypto: ccp - Use int type to store negative error
 codes

On 9/3/25 08:25, Qianfeng Rong wrote:
> Change the 'ret' variable in __sev_do_cmd_locked() from unsigned int to
> int, as it needs to store negative error codes.
> 
> No effect on runtime.
> 
> Signed-off-by: Qianfeng Rong <rongqianfeng@...o.com>

Acked-by: Tom Lendacky <thomas.lendacky@....com>

Not sure it needs to be initialized either, but not worth changing that
as part of this patch.

> ---
>  drivers/crypto/ccp/sev-dev.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c
> index 4f000dc2e639..6c116f6f9b79 100644
> --- a/drivers/crypto/ccp/sev-dev.c
> +++ b/drivers/crypto/ccp/sev-dev.c
> @@ -848,9 +848,10 @@ static int __sev_do_cmd_locked(int cmd, void *data, int *psp_ret)
>  	struct sev_device *sev;
>  	unsigned int cmdbuff_hi, cmdbuff_lo;
>  	unsigned int phys_lsb, phys_msb;
> -	unsigned int reg, ret = 0;
> +	unsigned int reg;
>  	void *cmd_buf;
>  	int buf_len;
> +	int ret = 0;
>  
>  	if (!psp || !psp->sev_data)
>  		return -ENODEV;