linux-kernel - Re: [PATCH] pinctrl: airoha: fix wrong MDIO function bitmaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d1bc3887-5b88-4fb9-8f89-4b520427ccdc@lunn.ch>
Date: Mon, 8 Sep 2025 21:06:03 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Christian Marangi <ansuelsmth@...il.com>
Cc: Lorenzo Bianconi <lorenzo@...nel.org>, Sean Wang <sean.wang@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Matthias Brugger <matthias.bgg@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	Benjamin Larsson <benjamin.larsson@...exis.eu>,
	linux-mediatek@...ts.infradead.org, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	stable@...r.kernel.org
Subject: Re: [PATCH] pinctrl: airoha: fix wrong MDIO function bitmaks

On Mon, Sep 08, 2025 at 07:48:17PM +0200, Christian Marangi wrote:
> On Mon, Sep 08, 2025 at 06:54:15PM +0200, Andrew Lunn wrote:
> > On Mon, Sep 08, 2025 at 01:37:19PM +0200, Christian Marangi wrote:
> > > With further testing with an attached Aeonsemi it was discovered that
> > > the pinctrl MDIO function applied the wrong bitmask. The error was
> > > probably caused by the confusing documentation related to these bits.
> > > 
> > > Inspecting what the bootloader actually configure, the SGMII_MDIO_MODE
> > > is never actually set but instead it's set force enable to the 2 GPIO
> > > (gpio 1-2) for MDC and MDIO pin.
> > 
> > Is the MDIO bus implemented using the GPIO bitbanging driver?
> > 
> 
> No it does use the MDIO bus integrated in the MT7530 Switch. It's just
> that the MDIO pin can be muxed as GPIO usage.

Then i do not understand this patch. Why configure the pinmux for GPIO
when you want it connected to the MDIO bus device?

     Andrew