[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0e030e7d-0a1a-4a00-ba18-ed26107d07fa@oss.qualcomm.com>
Date: Mon, 8 Sep 2025 09:20:00 +0200
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Aleksandrs Vinarskis <alex@...arskis.com>,
Hans de Goede <hansg@...nel.org>, Lee Jones <lee@...nel.org>,
Pavel Machek <pavel@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley
<conor+dt@...nel.org>,
Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
Daniel Thompson <danielt@...nel.org>,
Jingoo Han <jingoohan1@...il.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Jean-Jacques Hiblot <jjhiblot@...phandler.com>,
Jacopo Mondi <jacopo@...ndi.org>,
Sakari Ailus
<sakari.ailus@...ux.intel.com>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>
Cc: linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org,
Daniel Thompson <daniel.thompson@...aro.org>,
dri-devel@...ts.freedesktop.org, linux-media@...r.kernel.org,
linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v3 2/4] dt-bindings: leds: commonize leds property
On 9/8/25 1:18 AM, Aleksandrs Vinarskis wrote:
> A number of existing schemas use 'leds' property to provide
> phandle-array of LED(s) to the consumer. Additionally, with the
> upcoming privacy-led support in device-tree, v4l2 subnode could be a
> LED consumer, meaning that all camera sensors should support 'leds'
> and 'led-names' property via common 'video-interface-devices.yaml'.
>
> To avoid dublication, commonize 'leds' property from existing schemas
> to newly introduced 'led-consumer.yaml'.
>
> Signed-off-by: Aleksandrs Vinarskis <alex@...arskis.com>
> ---
[...]
>
> + leds:
> + minItems: 1
> + maxItems: 1
My brain compiler suggests this will throw a warning (minItems should
be redundant in this case)
> +
> + led-names:
> + enum:
> + - privacy-led
Nit: "privacy" makes more sense without the suffix, as we inherently
know this is supposed to be an LED
Konrad
Powered by blists - more mailing lists