[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20250908121303.180886-2-thorsten.blum@linux.dev>
Date: Mon, 8 Sep 2025 14:13:04 +0200
From: Thorsten Blum <thorsten.blum@...ux.dev>
To: Alexander Viro <viro@...iv.linux.org.uk>,
Christian Brauner <brauner@...nel.org>,
Jan Kara <jack@...e.cz>
Cc: linux-s390@...r.kernel.org,
Thorsten Blum <thorsten.blum@...ux.dev>,
linux-fsdevel@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: [PATCH] initrd: Fix unused variable warning in rd_load_image() on s390
The local variable 'rotate' is not used on s390, and building the kernel
with W=1 generates the following warning:
init/do_mounts_rd.c:192:17: warning: variable 'rotate' set but not used [-Wunused-but-set-variable]
192 | unsigned short rotate = 0;
| ^
1 warning generated.
Fix this by declaring and using 'rotate' only when CONFIG_S390 is not
defined.
Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
---
init/do_mounts_rd.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/init/do_mounts_rd.c b/init/do_mounts_rd.c
index ac021ae6e6fa..cbc4c496cb5f 100644
--- a/init/do_mounts_rd.c
+++ b/init/do_mounts_rd.c
@@ -189,9 +189,9 @@ int __init rd_load_image(char *from)
unsigned long rd_blocks, devblocks;
int nblocks, i;
char *buf = NULL;
- unsigned short rotate = 0;
decompress_fn decompressor = NULL;
#if !defined(CONFIG_S390)
+ unsigned short rotate = 0;
char rotator[4] = { '|' , '/' , '-' , '\\' };
#endif
@@ -249,7 +249,9 @@ int __init rd_load_image(char *from)
for (i = 0; i < nblocks; i++) {
if (i && (i % devblocks == 0)) {
pr_cont("done disk #1.\n");
+#if !defined(CONFIG_S390)
rotate = 0;
+#endif
fput(in_file);
break;
}
--
2.51.0
Powered by blists - more mailing lists