linux-kernel - Re: [PATCH] drm/tiny/bochs: Convert dev_err() to drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b8e91a2b-06e5-4ede-85b4-169e84e65528@suse.de>
Date: Mon, 8 Sep 2025 14:16:10 +0200
From: Thomas Zimmermann <tzimmermann@...e.de>
To: Leander Kieweg <kieweg.leander@...il.com>,
 Gerd Hoffmann <kraxel@...hat.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>
Cc: virtualization@...ts.linux.dev, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/tiny/bochs: Convert dev_err() to drm_err()

Hi

Am 18.08.25 um 13:35 schrieb Leander Kieweg:
> The DRM subsystem has a set of preferred, prefixed logging functions
> (drm_info, drm_warn, drm_err) which improve debuggability by including
> the driver and function name in the log output.
>
> As part of the ongoing effort to modernize logging calls,
> convert a dev_err() call in the bochs hardware initialization
> function to its drm_err() equivalent.
>
> This work was suggested by the DRM TODO list.
>
> Signed-off-by: Leander Kieweg <kieweg.leander@...il.com>

Reviewed-by: Thomas Zimmermann <tzimmermann@...e.de>

I'll soon add the patch to our tree.

Best regards
Thomas

> ---
>   drivers/gpu/drm/tiny/bochs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tiny/bochs.c b/drivers/gpu/drm/tiny/bochs.c
> index 8d3b7c4fa6a4..d2d5e9f1269f 100644
> --- a/drivers/gpu/drm/tiny/bochs.c
> +++ b/drivers/gpu/drm/tiny/bochs.c
> @@ -252,7 +252,7 @@ static int bochs_hw_init(struct bochs_device *bochs)
>   		}
>   		bochs->ioports = 1;
>   	} else {
> -		dev_err(dev->dev, "I/O ports are not supported\n");
> +		drm_err(dev, "I/O ports are not supported\n");
>   		return -EIO;
>   	}
>   

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)